840611 - Fix build on big endian archs after bug 834242

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

Atm m-c doesnt build for me on ppc32/openbsd, but that looks unrelated to that diff :

 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp: In function 'bool js::XDRAtom(js::XDRState<mode>*, js::MutableHandleAtom)':
 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp:519:42: error: no matching function for call to 'AtomizeChars(JSContext*&, jschar*&, uint32_t&)'
 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp:519:42: note: candidate is:
 5:03.09 /home/landry/src/mozilla-central/js/src/jsatom.cpp:406:1: note: template<js::AllowGC allowGC> JSAtom* js::AtomizeChars(JSContext*, const jschar*, size_t, js::InternBehavior)


Bug 834242 apparently missed the Big Endian side in jastom.cpp line 516, adding <CanGC> there fixes the build for me. Patch in a few.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Add missing <CanGC> template for BE archs

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 712999 [details] [diff] [review]
Add missing <CanGC> template for BE archs

Review of attachment 712999 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the fix!

Comment 3

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57dc48d44b60

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57dc48d44b60