Fix build on big endian archs after bug 834242

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

21 Branch
mozilla21
PowerPC
OpenBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Atm m-c doesnt build for me on ppc32/openbsd, but that looks unrelated to that diff :

 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp: In function 'bool js::XDRAtom(js::XDRState<mode>*, js::MutableHandleAtom)':
 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp:519:42: error: no matching function for call to 'AtomizeChars(JSContext*&, jschar*&, uint32_t&)'
 5:03.08 /home/landry/src/mozilla-central/js/src/jsatom.cpp:519:42: note: candidate is:
 5:03.09 /home/landry/src/mozilla-central/js/src/jsatom.cpp:406:1: note: template<js::AllowGC allowGC> JSAtom* js::AtomizeChars(JSContext*, const jschar*, size_t, js::InternBehavior)


Bug 834242 apparently missed the Big Endian side in jastom.cpp line 516, adding <CanGC> there fixes the build for me. Patch in a few.
(Assignee)

Comment 1

5 years ago
Created attachment 712999 [details] [diff] [review]
Add missing <CanGC> template for BE archs
Assignee: general → landry
Attachment #712999 - Flags: review?(terrence)
Comment on attachment 712999 [details] [diff] [review]
Add missing <CanGC> template for BE archs

Review of attachment 712999 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the fix!
Attachment #712999 - Flags: review?(terrence) → review+
(Assignee)

Updated

5 years ago
Version: Trunk → 21 Branch
https://hg.mozilla.org/mozilla-central/rev/57dc48d44b60
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.