Closed Bug 840661 Opened 7 years ago Closed 7 years ago

Android PGO: failure in expandlibs_exec when building with SYMBOL_ORDER

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 21

People

(Reporter: gbrown, Assigned: glandium)

References

Details

Attachments

(1 file)

In support of bug 781179, I am trying to build Fennec with PGO. I have valgrind'ed and generated a symbol list. When I run:

make -C <objdir-pgo>/toolkit/library SYMBOL_ORDER=/tmp/pgolist

after several minutes of effort, the build fails:

Traceback (most recent call last):
  File "/home/mozdev/src/config/expandlibs_exec.py", line 322, in <module>
    main()
  File "/home/mozdev/src/config/expandlibs_exec.py", line 300, in main
    args.orderSymbols(options.symbol_order)
  File "/home/mozdev/src/config/expandlibs_exec.py", line 169, in orderSymbols
    sections = self._getOrderedSections([l.strip() for l in file.readlines() if l.strip()])
  File "/home/mozdev/src/config/expandlibs_exec.py", line 145, in _getOrderedSections
    folded = self._getFoldedSections()
  File "/home/mozdev/src/config/expandlibs_exec.py", line 134, in _getFoldedSections
    result[quoted[5]].append(quoted[1])
AttributeError: 'str' object has no attribute 'append'
make[1]: *** [libxul.so] Error 1
Assignee: gbrown → mh+mozilla
Yes - that works! Thanks much.
Blocks: 781179
Comment on attachment 713062 [details] [diff] [review]
Fix ExpandArgsMore._getFoldedSections

To whoever gets here first.
Attachment #713062 - Flags: review?(ted)
Attachment #713062 - Flags: review?(khuey)
Attachment #713062 - Flags: review?(gps)
Attachment #713062 - Flags: review?(ted)
Attachment #713062 - Flags: review?(khuey)
Attachment #713062 - Flags: review?(gps)
Attachment #713062 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d5dcdeae4bd2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.