Closed Bug 84069 Opened 23 years ago Closed 23 years ago

Offline: "Download/Sync Now" only d/l's half of unread messages in newgroup

Categories

(SeaMonkey :: MailNews: Backend, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: trix, Assigned: Bienvenu)

References

Details

(Whiteboard: [nsbeta1+][PDT+])

Attachments

(1 file)

Occurence:
All the time

Steps:
1. In Mail/News, go to existing newsgroup which has already several messages
that were read. (Get more messages if you feel more are available).
2. Keep track of total unread messages.
3. Goto and select File\Offline\"Download/Sync Now..".
4. In dialog box, select "Newsgroup Messages" to download and click the "Select"
button. Select that newsgroup and click OK and then OK to begin the download.
5. Go offline and try to read the unread messages.

Result:
Half of the unread messages were downloaded.

Expected:
All unread messages should have been downloaded.
I don't know if I'm right, but it seems to me, that an internal index counter is 
incremented two times. If you watch the download process you can see, that every 
second article is downloaded.
So I looked into the source I got about 2 weeks ago and tried to identify the 
cause.
Perhaps I found it. (I really tried to understand the code, but it is badly 
documented and somewhat complex)

In nsNewsDownLoader.cpp (from date 2001-05-17) seems to be the function that 
retrieves the next artikel

  nsNewsDownloader::DownloadNext(PRBool firstTimeP)

it calls

  PRBool nsNewsDownloader::GetNextHdrToRetrieve()

to get the next header.
In line 197

  m_keyToDownload = m_keysToDownload.GetAt(m_numwrote++);

we get the next key with the index counter m_numwrote and postincrement (the 
right word?) the counter.
When we return to DownloadNext the counter is increment again - see line 123.

I think the incrementation in line 197 could be deleted ->

  m_keyToDownload = m_keysToDownload.GetAt(m_numwrote);

because there is all in all only the updating of status information done.

In the moment I'm not able to compile the browser and so I can't test my idea. 
It would be great, if an _insider_ could review and test it or give some 
feedback.


(Sorry for my bad english...)
Marcus, you very well could be right. I'll look into it when I get a chance.
can I get a code review on this patch? Thanks! And a ptd+ if I can.
Status: NEW → ASSIGNED
Attached patch proposed fixSplinter Review
Keywords: nsbeta1
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
r=naving
adding PDT+ per email from selmer.
Whiteboard: [nsbeta1+] → [nsbeta1+][PDT+]
sr=bienvenu for fix proposed by marcus.spranger@gmx.de
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Using commercial trunk builds
2001061504 -win nt 4.0
2001061508 -linux 2.2, red hat 7.0
2001061508 -mac os 9.0.4

Tried downloading newsgroup with some new messages & some read messages
and a group with new unread messages that i had
previously subsribed to.

Following Trix's steps to reproduce:
No problem. Both read and unread messages are downloaded. No
'every other message downloaded' problem anymore. You can
read the messages when you go offline.

Marking as verified.

Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: