84070 - Crash after close search when search in progress, try search again

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using may31 commercial trunk build
Using jun04 commercial 0.9.1 branch build

If you close the search messages ui while an account-wide search is still in
progress then try to access search messages ui again, a crash occurs.  

Steps:
1.  Go to mail window, login to IMAP account (which has lots of folders).
2.  Search|Search Mail/News Messsages.  Select the Account level for your IMAP
account, then initiate a simple search which will take awhile.  I used "subject
contains a".
3.  At the point where you see first batch of results display and search is
still in progress, click the Close button (don't click Stop before that).
4.  Back at the mail window, open search messages again and try to initiate a
search.  Note: Mac crashes immediately just accessing search ui. Win98 lets me
into search and access criteria before crashing. Linux allows access to search
ui, but hangs.

Result:  crash occurs after trying to access search again.

Notes:
1.  I do not crash if I don't try to access search again.
2.  I do not crash if I've first used Stop button in search ui before closing.

Comment 1

[laurel]

Attachment: talkback 31314864

Comment 2

[Navin Gupta]

looks like we are not calling stop when we are closing. 

Comment 3

[Navin Gupta]

Attachment: proposed fix.

Comment 4

[Navin Gupta]

This happens when you use the close button on the search window. stopSearch 
before closing the window. need review, david. cc sspitzer for review.

Comment 5

[scottputterman]

putting on 0.9.1 radar

Comment 6

[selmer (gone)]

Please get the reviews and then propose for approval ASAP.

Comment 7

[David :Bienvenu]

r=bienvenu.

Comment 8

[(not reading, please use [e-mail] instead)]

hold up here.   

we have an onclose="" handler for this window that calls onSearchStop()

is that not getting called? or is it getting called too late?

if so, do we also crash if the user uses the window manager [x] to close the
window?  (your fix just addresses the case where we hit the "Close" button).

does the onunload="" get called early enough?  (I'm not sure if it gets called
before or after onclose="".)  if so, perhaps we can call onSearchStop() from
there, remove the onclose="" handler, and fix this for both cases.  (assuming
window manager [x] has the same problem.)

Comment 9

[Navin Gupta]

onclose does not get called when we close using the close button.

Comment 10

[Navin Gupta]

everything worksfine when we use X on the search window.

Comment 11

[Navin Gupta]

I just talked to seth and he says sr=sspitzer. onclose handler should get 
called on window.close(), this will be dealt with in another bug.  

Comment 12

[Marek Z. Jeziorek]

ok, let get drivers approval and try and get it in tonight if we can.

Comment 13

[Navin Gupta]

waiting for approval to check this in. 

Comment 14

[(not reading, please use [e-mail] instead)]

bug #84256 logged on the onclose="" issue

Comment 15

[chris hofmann]

a=chofmann for 0.9.1 branch and trunk

Comment 16

[Navin Gupta]

fix checked into both branch and trunk

Comment 17

[Navin Gupta]

Marking fixed 

Comment 18

[laurel]

OK on branch commercial build: 2001-06-06-12-0.9.1 win98

Comment 19

[laurel]

OK using commercial branch builds:
2001-06-06-12-0.9.1 mac OS 9.0
2001-06-06-13-0.9.1 linux rh6.2

Comment 20

[laurel]

added vtrunk keyword

Comment 21

[laurel]

OK using june14 commercial trunk builds: win98, mac OS 9.0, linux rh6.2