840716 - Store & Serve Video Thumbnails From Flicks

Status: VERIFIED FIXED

(Websites :: Firefox Flicks, defect)

Description

[Ben (:bensternthal)]

Firefox will eventually implement "Mixed Content Blocker" this will prevent http:// assets like images from loading on https sites.

For flicks this means the video thumbnails will need to be served from a HTTPS server. Unfortunately the vimeo thumb server has an invalid cert, and according to the forums..

"We don't allow direct linking to thumbnails, so I suggest finding a different method. Sorry."

I think this means we need to retrieve the thumbnail and serve from the flicks site. This could be done during moderation on "approval".

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/firefox-flicks

https://github.com/mozilla/firefox-flicks/commit/a3028ebacf40607abb76962fa5c0c286fe037733
Bug 840716: Download thumbnail image instead of storing URLs.

- Adds an admin command to download thumbnails for existing videos.
- Alters the approval processing to happen synchronously on save instead
  of asynchronously via celery to help lower the risk of making a video
  public before it is fully processed.
- Move approval email outside of process_approval to avoid emailing the
  user before the video changes have completed and been saved 
  successfully.
- Bug 840717: Only show pagination if there is more than one page of
  results.
- send_approval_email now uses the default locale if the user doesn't
  have a locale or profile.
- Improve test patching to avoid contacting outside services during
  tests.

Comment 2

[Osmose [:osmose, :mkelly]]

Flicks-dev is now downloading and storing thumbnails correctly. To verify, we need to upload a video, approve it, and then confirm that once the video is approved, it shows up on the video listing page (https://firefoxflicks-dev.allizom.org/en-US/video/ for dev) along with the correct thumbnail, as well as confirming that the thumbnail is being downloaded from Flicks and not Vimeo.

Comment 3

[Ben (:bensternthal)]

I tested this on 2 videos.

Shows up on listing page.

Thumbnail is from flicks.

Comment 4

[Rebecca Billings [:rbillings]]

Verified on dev, video displays with thumb being served from Flicks.