840790 - [B2G][First Time User]Wrong or Modified names for various locations

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Jeni]

All City names are listed with official name inside the drop down for cities in Date & Time

example: Ho Chi Minh  officially is Ho Chi Minh City.


Repro Steps:
1) Turn device on for first time user(Can also access first time user from settings/Device information/More info/Developer)
2) Click on Buttons until you get to Date & Time
3) Select first drop down menu and select Asia
4) Select Second drop down menu
5) View whats listed

Expected:
All Cities are listed as officially named

Actual:
Ho Chi Minh City is official listing and currently listed as Ho Chi Minh

Notes: If you look up Ho Chi Minh without city it shows as a man with that name.  if you scroll down on the search you will see the city listed as Ho Chi Minh City which is located in Vietnam, Asia

Kernel Dec 5
Build 20130212070205
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/2ae874433a14
Gaia   ecca2ee860825547d5e1109436b50b74dfe9261e

Comment 1

[Jeni]

This city is also formally known as Siagon which is also listed on device.

Comment 2

[Jeni]

Azores actually a bunch of Islands and is called both Azores Island or officially is called The Archipelago of the Azores located in the North Atlantic Ocean.

Comment 3

[Jeni]

South Georgia is known officially as South Georgia Island and is located in South Georgia and the South Sandwich Islands in the Atlantic Ocean

Comment 4

[Jeni]

Lindeman is officially know as Lindeman Island which is off the coast of Queensland, Australia.

Comment 5

[Jeni]

Lord Howe is officially known as Lord Howe Island located off of the Australia coast.

Comment 6

[Jeni]

Vatican is officially known as Vatican City and is located in Italy which is located i Europe.

Comment 7

[Jeni]

Christmas is officially known as Christmas City and is located in the Indian Ocean

Comment 8

[Jeni]

Cocos i officially known as Cocos (Keeling) Islands is located in the Indian Ocean.

Comment 9

[Jeni]

Comoro is officially known as Comoro Islands or Comoros and is located in the Indian Ocean.

Comment 10

[Jeni]

Kerguelen is officially known as Kerguelen Island and is located in the Indian Ocean

Comment 11

[Jeni]

Issue repros 
Unagi Build ID: 20130313070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/2a8c49f56bb6
Gaia: acd6546cdd03284b3b8c12432fb9955868fc4c2b
Update Channel: Nightly
Names are not listed on device as their official names.

Comment 12

[Jeni]

Issue repros on 
Unagi Build ID: 20130405070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1d4c7fe3256e
Gaia: 2f64311e0f23b85c29b20be9502cbdeaee8342ae

Names are not shown on device with official city names.  On this version North Atlantic Ocean and cities are no longer listed

Comment 13

[Jeni]

However Atlantic Ocean is now listed and Azores and South Georgia Are not listed as they are officially known.  

Also Galapagos listed under Pacific Ocean is officially known as Galapagos Islands

Comment 14

[Jeni]

Issue repros in
Inari Build ID: 20130501070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: 09046df332cd217cf4fad55c48ce9ce3f14ee5a4

And in

Unagi Build ID: 20130501070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: 09046df332cd217cf4fad55c48ce9ce3f14ee5a4

Names are not shown on device with the official city names.  North Atlantic Ocean is now listed as Atlantic Ocean.

Comment 15

[Jeni]

Issue still repros on 

Build ID: 20130723070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: ffe25bfdf0e71c820ca710cb61fb8306564a8f4e
Platform Version: 18.1
RIL Version: 01.01.00.019.158 

Names are not shown on device with official city names.  On this version North Atlantic Ocean is now listed as Atlantic Ocean

Comment 16

[Jeni]

Issue repros on Leo

Build ID: 20130815041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
Platform Version: 18.1
RIL Version: 01.01.00.019.190 

Names are not shown on device with official city names.

Comment 17

[Anusha]

Hi,
I would like to work on this bug,
Thanks

Comment 18

[Anusha]

Attachment: Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Atlantic is not changed to North Atlantic since it has both the Islands of North and South Atlantic.

Comment 19

[kumar rishav (:rishav_)]

Comment on attachment 8491994 [details] [diff] [review]
Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Hi anusha
Please attach the valid patch.I didn't find any patch.
First ask for feedback, after getting feedback+, then only ask for review.
Cancelling the review and feedback for now. Ask for feedback after attaching the valid patch.
Thanks

Comment 20

[Anusha]

Attachment: Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Atlantic is not changed to North Atlantic since the "Atlantic" consists of places which is present both in South and North Atlantic Ocean

Comment 21

[kumar rishav (:rishav_)]

Comment on attachment 8492027 [details] [review]
Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Hi anusha
Saigon should be removed as  Ho chin Minh city was formally known by this name.
For Azores use the offcial name which is given in comment 1.
For Vatican use the offcial name given in comment 6
Galapagos listed under Pacific Ocean is officially known as Galapagos Islands (comment 13).
Ask for feedback after correcting these.
Thanks

Comment 22

[Anusha]

Attachment: Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Comment 23

[kumar rishav (:rishav_)]

Hey Anusha
Seems like you didn't update your repository after landing this patch bug 840749. Update the repo and rebase this branch with master and then ask for needinfo.

if don't know how to rebase the branch, use following command.
got to master branch

git fetch upstream
git merge upstream/master
git push --all

switch to this branch now
git rebase master
git push -f

Thanks

Comment 24

[kumar rishav (:rishav_)]

Hey Anusha
While rebasing you will have to solve merge conflicts or another option is to create a new branch(after rebasing) and send a new pull request.
ni? if you have any doubt.
Fix this, otherwise you patch is good to go.
Thanks

Comment 25

[Anusha]

Attachment: Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device #25291

Comment 26

[kumar rishav (:rishav_)]

Comment on attachment 8492027 [details] [review]
Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device

Hi
Patch looks to me. Tested on device.
As i am not the peer, ask fernando ([e-mail]) for review.
Thanks

Comment 27

[kumar rishav (:rishav_)]

Comment on attachment 8507346 [details] [review]
Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device #25291

Commented on wrong patch.Sorry for the previous one.
Ask fernando ([e-mail]) for review.
Thanks

Comment 28

[Fernando Campo (:fcampo)]

Comment on attachment 8507346 [details] [review]
Bug 840790 - [B2G][First Time User]Date & Time - Ho Chi Minh City displays as HO Chi Minh on device #25291

Code is perfectly ok, but if we are gonna change the name of all those cities, we should morph the bug name for something more clear, instead of referring only to one of the changes e.g. Wrong names for various locations.

P.D. remember to change the commit message accordingly.

Comment 29

[kumar rishav (:rishav_)]

Hi anusha
Change the commit messages of patch(as title of bug got changed to make it more general).
Thanks

Comment 30

[Anusha]

The commit message has been modified. The patch is ready to merge.
Thanks

Comment 31

[kumar rishav (:rishav_)]

Hi Fernando
Now patch seems good. Have a look on this :) 
Thanks

Comment 32

[Fernando Campo (:fcampo)]

Yeah, everything ok :) ready to merge
Thanks for all the changes

Comment 33

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/763683f27482075caaed47f9348e84ebf8a175d5

Comment 34

[Michael Henretty [:mikehenrty][:mhenretty]]

Backed out for causing bug 1122503.

master: https://github.com/mozilla-b2g/gaia/commit/e058a2ae496b9885fb26663c3b40fd62e579a39e

Comment 35

[Michael Henretty [:mikehenrty][:mhenretty]]

Backed out of 2.2:

https://github.com/mozilla-b2g/gaia/commit/c2047a46e29696238e9b4c9caaba47736421449a

Comment 36

[Sam Foster [:sfoster] (he/him)]

:flod, do you know what needs to happen to get this patch landed again? I see many files under mozilla-central/intl with these timezone city/region names, but I'm not clear which need to change or what that process should be to ensure we don't fall into the same trap.

Comment 37

[Francesco Lodolo [:flod]]

(In reply to Sam Foster [:sfoster] from comment #36)
> :flod, do you know what needs to happen to get this patch landed again? I
> see many files under mozilla-central/intl with these timezone city/region
> names, but I'm not clear which need to change or what that process should be
> to ensure we don't fall into the same trap.

Unfortunately I don't have this information. As far as I know ICU is an external library, so it needs to be fixed upstream (or maybe just update our copy).

The last bug I can find is bug 924839 (ICU 52.1), the last release is 54.1 based on CLDR26
http://site.icu-project.org/download

Comment 38

[Francesco Lodolo [:flod]]

One more note: checking CLDR, I don't think updating the library would change anything. Example for "Azores"
http://www.unicode.org/cldr/charts/latest/by_type/timezones.europe.html#Azores

Comment 39

[kumar rishav (:rishav_)]

Any updates?

Comment 40

[BMO Automation]

Firefox OS is not being worked on