840843 - Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_NotNeeded

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Since RasterImage::eShutdownIntent_Interrupted is used to indicate that a decode is no longer needed (for example, because it's a size decode and we now need a full decode) we should make that a bit more explicit and rename it to eShutdownIntent_Unneeded.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded.

Proposed patch.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Let me know what you think, Joe. After reviewing your OMTD patches I thought that this name would've been a little bit clearer.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 713249 [details] [diff] [review]
Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded.

Review of attachment 713249 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/RasterImage.h
@@ +320,5 @@
>  
>    // Decoder shutdown
>    enum eShutdownIntent {
>      eShutdownIntent_Done        = 0,
> +    eShutdownIntent_Unneeded    = 1,

I prefer the more grammatical "NotNeeded" but listen to your heart on this.

Comment 4

[Seth Fowler [:seth] [:s2h]]

I'm cool with NotNeeded. Thanks for the review.

Comment 5

[Seth Fowler [:seth] [:s2h]]

Attachment: Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded.

Final version of patch.

Comment 6

[Seth Fowler [:seth] [:s2h]]

Requesting checkin. Not going to waste try resources on this as it's purely an identifier rename (meaning if it compiles, which it does, it should work fine).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f096c747df

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e1f096c747df