Closed
Bug 840843
Opened 11 years ago
Closed 11 years ago
Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_NotNeeded
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: seth, Assigned: seth)
Details
Attachments
(1 file, 1 obsolete file)
Since RasterImage::eShutdownIntent_Interrupted is used to indicate that a decode is no longer needed (for example, because it's a size decode and we now need a full decode) we should make that a bit more explicit and rename it to eShutdownIntent_Unneeded.
Assignee | ||
Comment 2•11 years ago
|
||
Let me know what you think, Joe. After reviewing your OMTD patches I thought that this name would've been a little bit clearer.
Comment 3•11 years ago
|
||
Comment on attachment 713249 [details] [diff] [review] Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded. Review of attachment 713249 [details] [diff] [review]: ----------------------------------------------------------------- ::: image/src/RasterImage.h @@ +320,5 @@ > > // Decoder shutdown > enum eShutdownIntent { > eShutdownIntent_Done = 0, > + eShutdownIntent_Unneeded = 1, I prefer the more grammatical "NotNeeded" but listen to your heart on this.
Attachment #713249 -
Flags: review?(joe) → review+
Assignee | ||
Comment 4•11 years ago
|
||
I'm cool with NotNeeded. Thanks for the review.
Summary: Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded → Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_NotNeeded
Assignee | ||
Comment 5•11 years ago
|
||
Final version of patch.
Assignee | ||
Updated•11 years ago
|
Attachment #713249 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
Requesting checkin. Not going to waste try resources on this as it's purely an identifier rename (meaning if it compiles, which it does, it should work fine).
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f096c747df
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e1f096c747df
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•