Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_NotNeeded

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

6 years ago
Since RasterImage::eShutdownIntent_Interrupted is used to indicate that a decode is no longer needed (for example, because it's a size decode and we now need a full decode) we should make that a bit more explicit and rename it to eShutdownIntent_Unneeded.
Assignee

Comment 2

6 years ago
Let me know what you think, Joe. After reviewing your OMTD patches I thought that this name would've been a little bit clearer.
Comment on attachment 713249 [details] [diff] [review]
Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded.

Review of attachment 713249 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/RasterImage.h
@@ +320,5 @@
>  
>    // Decoder shutdown
>    enum eShutdownIntent {
>      eShutdownIntent_Done        = 0,
> +    eShutdownIntent_Unneeded    = 1,

I prefer the more grammatical "NotNeeded" but listen to your heart on this.
Attachment #713249 - Flags: review?(joe) → review+
Assignee

Comment 4

6 years ago
I'm cool with NotNeeded. Thanks for the review.
Summary: Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_Unneeded → Rename RasterImage::eShutdownIntent_Interrupted to eShutdownIntent_NotNeeded
Assignee

Updated

6 years ago
Attachment #713249 - Attachment is obsolete: true
Assignee

Comment 6

6 years ago
Requesting checkin. Not going to waste try resources on this as it's purely an identifier rename (meaning if it compiles, which it does, it should work fine).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e1f096c747df
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.