Closed Bug 840850 Opened 7 years ago Closed 7 years ago
Fix missing include guard and various style issues in Image
There are some cosmetic issues in ImageFactory that I want to resolve. Also, the file is missing a |#pragma once| declaration, which has fortunately not caused a problem so far but could cause issues in the future.
Attachment #713254 - Flags: review?(joe)
Comment on attachment 713254 [details] [diff] [review] Fix missing #pragma once and style issues in ImageFactory. Review of attachment 713254 [details] [diff] [review]: ----------------------------------------------------------------- This is going to make pull --rebase painful, I just know it :( ::: image/src/ImageFactory.h @@ +3,5 @@ > * This Source Code Form is subject to the terms of the Mozilla Public > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > +#pragma once Instead, please use the #ifndef MOZILLA_IMAGELIB_IMAGEFACTORY_H_ style of header guards.
Attachment #713254 - Flags: review?(joe) → review+
Thanks for the review! I'll update the patch later today. (In reply to Joe Drew (:JOEDREW! \o/) from comment #2) > This is going to make pull --rebase painful, I just know it :( Yeah, sorry about that. Seems like most imagelib changes of any substance are going to do that to you right now. =)
Attachment #713254 - Attachment is obsolete: true
Summary: Fix missing #pragma once and various style issues in ImageFactory → Fix missing include guard and various style issues in ImageFactory
Now with updated description.
Attachment #713622 - Attachment is obsolete: true
No need to waste try resources on this since this patch only changes comments, whitespace, and preprocessor directives. Requesting checkin.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.