Closed
Bug 840856
Opened 10 years ago
Closed 10 years ago
Reproducible crash in gfxContext::gfxContext
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
3.27 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-396c999f-a64c-45d6-94a9-149df2130213 . ============================================================= I think this is an OOM crash but I'm sure. We're crashing on a null de-reference. My process is at about 1.5GB of RAM so we shouldn't be failing an allocation on a 64-bit mac build with 16GB of memory (8GB free). Hosting the file since it's 18MB: https://dl.dropbox.com/u/10523664/galaxymapgl-OOM.tar.gz STR: 1) Open index.html, select all the stars 2) Wait for the stars to loads 3) Typically I get a crash before all the stars load but sometimes I have to reload a few times
Assignee | ||
Comment 1•10 years ago
|
||
Caused by bug 593733, we don't check if the allocation succeeded or not: http://hg.mozilla.org/mozilla-central/annotate/36525224b14e/gfx/layers/opengl/ThebesLayerOGL.cpp#l734
Depends on: 593733
Assignee | ||
Comment 2•10 years ago
|
||
This restores the behavior before your patch landed.
Updated•10 years ago
|
Attachment #713261 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #0) > I think this is an OOM crash but I'm sure. We're crashing on a null > de-reference. My process is at about 1.5GB of RAM so we shouldn't be failing > an allocation on a 64-bit mac build with 16GB of memory (8GB free). > I had my build running in 32-bit mode so that explains why I was running out of memory so fast.
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ca584f4fe7
Updated•10 years ago
|
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e6ca584f4fe7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•