840873 - Opening a chat window from the sidebar resolves the chat URL twice.

Status: RESOLVED INVALID

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

The "openChat" function we expose on the mozSocial object has the following code:

      value: function(toURL, callback) {
        let url = targetWindow.document.documentURIObject.resolve(toURL);
        openChatWindow(getChromeWindow(targetWindow), provider, url, callback);
      }

and openChatWindow has:

  let fullURI = provider.resolveUri(url);
  if (!provider.isSameOrigin(fullURI))
    return;

It seems that when the chat URL is requested by the sidebar etc, it will be resolved against the sidebar URL, but when opened by the worker it will be resolved against the provider's origin.  There is no good reason for this inconsistency - the resolution against the "targetWindow" should probably be dropped so the same rules apply regardless of how it is opened.

Comment 1

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Attachment: Only resolve chat urls against the provider origin

trivial patch but requires a couple of changes to the tests.  If we are going to make this change, the sooner the better, or providers may start relying on the existing behaviour.  Fortunately, Facebook doesn't...

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 724760 [details] [diff] [review]
Only resolve chat urls against the provider origin

Patch is fine, but I want to keep relative url support in anything that is not part of the manifest.  We can fix worker api to relativize off the worker url.

Comment 3

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Apparently this is a feature!