840902 - Make display list construction infallible

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently various display list construction methods return nsresults so they can bail out on OOM. This is unnecessary. It would probably be fine to make OOM fatal for display list construction, but even if we don't do that we can just continue without inserting items that failed to allocate.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Stop checking the results of various display list methods

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: Remove nsresults from various display list methods

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://tbpl.mozilla.org/?tree=Try&rev=b8b5d36ad1a0

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed a missing "return" in BuildDisplayListForChild.
https://tbpl.mozilla.org/?tree=Try&rev=4f02c58567eb

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1905f6653d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bd3acba4c01

Comment 6

[Ed Morley [:emorley]]

Backed out for compilation failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1bd3acba4c01

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa45a2a3e49
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/86c8e1b819f1

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c860c4bb820
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c21598704ac

Comment 8

[Ed Morley [:emorley]]

Failed to build on all platforms (again); backed out:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17fa03776b5c

Please use Try before this lands again.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry, I'm not really sure what happened. I built it locally and somehow between then and checking in I deleted a line of code :-(.

Here's a Try push anyway: https://tbpl.mozilla.org/?tree=Try&rev=fb74ef663f1c

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Which is green.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/494483cbe311
https://hg.mozilla.org/integration/mozilla-inbound/rev/37cb11f41bb2

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/494483cbe311
https://hg.mozilla.org/mozilla-central/rev/37cb11f41bb2