Make display list construction infallible

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

18 Branch
mozilla21
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Currently various display list construction methods return nsresults so they can bail out on OOM. This is unnecessary. It would probably be fine to make OOM fatal for display list construction, but even if we don't do that we can just continue without inserting items that failed to allocate.
Attachment #713381 - Flags: review?(matt.woodrow) → review+
Attachment #713383 - Flags: review?(matt.woodrow) → review+
Failed to build on all platforms (again); backed out:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17fa03776b5c

Please use Try before this lands again.
Sorry, I'm not really sure what happened. I built it locally and somehow between then and checking in I deleted a line of code :-(.

Here's a Try push anyway: https://tbpl.mozilla.org/?tree=Try&rev=fb74ef663f1c
https://hg.mozilla.org/mozilla-central/rev/494483cbe311
https://hg.mozilla.org/mozilla-central/rev/37cb11f41bb2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.