Currently various display list construction methods return nsresults so they can bail out on OOM. This is unnecessary. It would probably be fine to make OOM fatal for display list construction, but even if we don't do that we can just continue without inserting items that failed to allocate.
Attachment #713381 - Flags: review?(matt.woodrow) → review+
Attachment #713383 - Flags: review?(matt.woodrow) → review+
Fixed a missing "return" in BuildDisplayListForChild. https://tbpl.mozilla.org/?tree=Try&rev=4f02c58567eb
Backed out for compilation failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1bd3acba4c01 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa45a2a3e49 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/86c8e1b819f1
Failed to build on all platforms (again); backed out: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17fa03776b5c Please use Try before this lands again.
Sorry, I'm not really sure what happened. I built it locally and somehow between then and checking in I deleted a line of code :-(. Here's a Try push anyway: https://tbpl.mozilla.org/?tree=Try&rev=fb74ef663f1c
Which is green.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.