Closed Bug 84100 Opened 19 years ago Closed 19 years ago

The nblayer.c test needs to override the accept I/O method.

Categories

(NSPR :: NSPR, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

The I/O layer in the nblayer.c test has a PRFilePrivate
structure that needs to be duplicated for an accepted
socket.  The default accept method does not do that.
It only copies the PRFileDesc structure, resulting
in the 'secret' field of an accepted socket pointing to
the PRFilePrivate structure of the listening socket.
When we close the accepted socket and the listening
socket, we free the PRFilePrivate structure twice.

We need to write our own accept method that copies not
only the PRFileDesc structure but also makes a copy of
the PRFilePrivate structure for an accept socket.
Attached patch Proposed patch.Splinter Review
Status: NEW → RESOLVED
Closed: 19 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → 4.2
I checked in my fix on the trunk of NSPR.
I merged this fix on the NSPRPUB_RELEASE_4_1_BRANCH to
help the testing of NSPR 4.1.2.
Target Milestone: 4.2 → 4.1.2
You need to log in before you can comment on or make changes to this bug.