841019 - [Email] Folder list styling concerns relating to gmail

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Gmail

Gmail accounts don't seem to be importing correctly. 

Couple of issues:
1) Some folders are indented making "inbox" look like a heading when they all should be on the same level (and left aligned with inbox)
2) Why is [Gmail] highlighted in white? (see bottom of attached screenshot)

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

We access Gmail via IMAP, but without much special-cased logic in how we handle it.  In IMAP, folders are exposed as a hierarchy.  Gmail's is exposed to us like this:

XLIST (\HasNoChildren \Inbox) "/" "Inbox"
XLIST (\Noselect \HasChildren) "/" "[Gmail]"
XLIST (\HasChildren \HasNoChildren \AllMail) "/" "[Gmail]/All Mail"
XLIST (\HasNoChildren \Drafts) "/" "[Gmail]/Drafts"
XLIST (\HasChildren \HasNoChildren \Important) "/" "[Gmail]/Important"
XLIST (\HasChildren \HasNoChildren \Sent) "/" "[Gmail]/Sent Mail"
XLIST (\HasNoChildren \Spam) "/" "[Gmail]/Spam"
XLIST (\HasNoChildren \Starred) "/" "[Gmail]/Starred"
XLIST (\HasChildren \HasNoChildren \Trash) "/" "[Gmail]/Trash"

There is a bug on our sorting in the face of the hierarchy, bug 829520 which should explain the seemingly random-indent and fix it.

[Gmail] is in white because it is marked \Noselect because it's not actually a folder that can hold messages; it only holds other folders.  In our CSS, we mark these folders with class fld-folder-unselectable.

I think these are the relevant CSS snippets:
.fld-folder-item.fld-folder-selected {
  background-color: rgba(0, 0, 0, 0.5);
  font-weight: bold;
}
.fld-folder-unselectable {
  color: #444;
  background-color: #eee;
}
.fld-account-item:active, .fld-folder-item:active, .fld-folder-list-header:active {
  border-color: #008aaa;
  background: #008aaa;
}


It seems like this bug probably wants to become about our styling for noselect folders, request specialization for gmail (which would need to be a post v1.1 enhancement, probably), or should be closed.