Closed
Bug 841039
Opened 13 years ago
Closed 13 years ago
add a make target for the leaktest tests we run at build time from the objdir
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
|
827 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
in order to use virtualenv for our test harnesses, the leaktest.py scripts run from the objdir and could benefit heavily from a make target.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 713452 [details] [diff] [review]
add make targets for the 3 tests we do during build time from the objdir (1.0)
Review of attachment 713452 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/testsuite-targets.mk
@@ +371,5 @@
> +leaktest:
> + $(PYTHON) _leaktest/leaktest.py
> +
> +leaktest-trace-malloc:
> + $(PYTHON) _leaktest/leaktest.py -- --trace-malloc malloc.log --shutdown-leaks=sdleak.log
I wonder if we couldn't just compress these into:
leaktest:
$(PYTHON) _leaktest/leaktest.py $(LEAKTEST_ARGS)
Attachment #713452 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•