Closed Bug 841039 Opened 11 years ago Closed 11 years ago

add a make target for the leaktest tests we run at build time from the objdir

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

add make targets for the 3 tests we do during build time from the objdir (1.0)
827 bytes, patch
ted
: review+
Details | Diff | Splinter Review 
in order to use virtualenv for our test harnesses, the leaktest.py scripts run from the objdir and could benefit heavily from a make target.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED

        Attachment #713452 -
        Flags: review?(ted)

    
    

    
  
Comment on attachment 713452 [details] [diff] [review]
add make targets for the 3 tests we do during build time from the objdir (1.0)

Review of attachment 713452 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +371,5 @@
> +leaktest:
> +	$(PYTHON) _leaktest/leaktest.py
> +
> +leaktest-trace-malloc:
> +	$(PYTHON) _leaktest/leaktest.py -- --trace-malloc malloc.log --shutdown-leaks=sdleak.log

I wonder if we couldn't just compress these into:
leaktest:
	$(PYTHON) _leaktest/leaktest.py $(LEAKTEST_ARGS)

        Attachment #713452 -
        Flags: review?(ted) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/db065fd3d40e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.