841047 - Strange behavior of Fullscreen button on localization edit page

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Frédéric Bourgeon [:FredB]]

What did you do?
================
1. Edit any non en-US doc
2. Click the full-screen button

What happened?
==============
The editor goes in full-screen, but the first line of button tools isn't visible in the viewport.

What should have happened?
==========================
All the tools in the editor should be visible in the full-screen mode.

Is there anything else we should know?
======================================
It works well in non-l10n UI.
The button to go back to the non-full-screen mode is on the first line, making impossible to go back to the "normal" mode and so blocks access to save buttons.

Comment 1

[John Karahalis [:openjck]]

Attachment: Floating WYSIWYG

Noticed another issue while testing this, so I thought I would generalize the bug report out to include it.

In addition to the problem mentioned in comment 0, the Fullscreen button sometimes causes the WYSIWYG toolbar to appear floating on the left side of the screen.

For design, the sign off is pretty simple. The Fullscreen button should work exactly as it does on normal pages, without any of the weirdness described in this comment or comment 0.

Comment 2

[David Walsh :davidwalsh]

Can I be provided steps to reproduce, or more browser info?  I'm not seeing either of the side-effects you are:

http://screencast.com/t/XrKMJ9Db7v

Comment 3

[John Karahalis [:openjck]]

I am on Firefox 19 / Linux. Try hitting the fullscreen button before scrolling the page at all. This usually causes comment 0. And then try scrolling a bunch and trying again. This usually causes comment 1.

Comment 4

[David Walsh :davidwalsh]

Followed the steps provided, can't reproduce.  Please provide a screenshot so I know what I'm looking for, or how it can somehow be prevented.

Comment 5

[John Karahalis [:openjck]]

Attachment: This is the entire viewport. Notice that the first row of buttons is missing.

Comment 6

[John Karahalis [:openjck]]

David: See comment 5 and comment 1.

Comment 7

[David Walsh :davidwalsh]

OK, I see it now;  didn't have enough content within the WYSIWYG.  Will look at now.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9b89067777330f28897cd3ea4125669012ea85b0
fix bug 841047 - Fix translation fullscreen issues

https://github.com/mozilla/kuma/commit/f050a7f96cb7f3d056b459c39545fa0c0d249b11
Merge pull request #870 from darkwing/fullscreen-841047

fix bug 841047 - Fix translation fullscreen issues

Comment 9

[John Karahalis [:openjck]]

Good stuff. Go David!