The default bug view has changed. See this FAQ.

FORBIDDEN_IDS in gDevTools is improperly initialized

RESOLVED FIXED in Firefox 22

Status

()

Firefox
Developer Tools: Framework
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: benvie, Assigned: benvie)

Tracking

21 Branch
Firefox 22
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The Set `FORBIDDEN_IDS` is initialized with two strings instead of an array of two strings. Since strings are iterable, the result is that the characters of the first string are individually added to the set, instead of two strings being added.
(Assignee)

Comment 1

4 years ago
Created attachment 713543 [details] [diff] [review]
change FORBIDDEN_IDS initializer to an array of strings
(In reply to Brandon Benvie from comment #1)
> Created attachment 713543 [details] [diff] [review]
> change FORBIDDEN_IDS initializer to an array of strings

Nice catch!
(Assignee)

Updated

4 years ago
Attachment #713543 - Flags: review?(rcampbell)
Comment on attachment 713543 [details] [diff] [review]
change FORBIDDEN_IDS initializer to an array of strings

r++++!!!
Attachment #713543 - Flags: review?(rcampbell) → review+
(Assignee)

Updated

4 years ago
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/06d0fa06a3c2
https://hg.mozilla.org/mozilla-central/rev/06d0fa06a3c2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.