Closed
Bug 841078
Opened 11 years ago
Closed 11 years ago
FORBIDDEN_IDS in gDevTools is improperly initialized
Categories
(DevTools :: Framework, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: bbenvie, Assigned: bbenvie)
Details
Attachments
(1 file)
|
798 bytes,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
The Set `FORBIDDEN_IDS` is initialized with two strings instead of an array of two strings. Since strings are iterable, the result is that the characters of the first string are individually added to the set, instead of two strings being added.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
(In reply to Brandon Benvie from comment #1) > Created attachment 713543 [details] [diff] [review] > change FORBIDDEN_IDS initializer to an array of strings Nice catch!
|
|
Assignee | |
Updated•11 years ago
|
Attachment #713543 -
Flags: review?(rcampbell)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 713543 [details] [diff] [review] change FORBIDDEN_IDS initializer to an array of strings r++++!!!
Attachment #713543 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/06d0fa06a3c2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•