Closed
Bug 841085
Opened 11 years ago
Closed 11 years ago
moznetwork.get_ip() returns None on Mac
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file)
|
409 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
Python 2.6.4 (r264:75821M, Oct 27 2009, 19:48:32)
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import moznetwork
>>> print moznetwork.get_ip()
None
This works fine on linux. This is problematic because Marionette now depends on moznetwork.get_ip(), and needs to run on OSX.
|
Assignee | |
Comment 1•11 years ago
|
||
Looks like this is just due to a missing return statement.
Attachment #713525 -
Flags: review?(wlachance)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 713525 [details] [diff] [review] Add missing return statement lgtm
Attachment #713525 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://github.com/mozilla/mozbase/commit/23ab82b5d26dad0db14817ae3841cf637dddcf5c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jgriffin
You need to log in
before you can comment on or make changes to this bug.
Description
•