moznetwork.get_ip() returns None on Mac

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Python 2.6.4 (r264:75821M, Oct 27 2009, 19:48:32) 
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import moznetwork
>>> print moznetwork.get_ip()
None

This works fine on linux.  This is problematic because Marionette now depends on moznetwork.get_ip(), and needs to run on OSX.
(Assignee)

Comment 1

5 years ago
Created attachment 713525 [details] [diff] [review]
Add missing return statement

Looks like this is just due to a missing return statement.
Attachment #713525 - Flags: review?(wlachance)
Comment on attachment 713525 [details] [diff] [review]
Add missing return statement

lgtm
Attachment #713525 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla/mozbase/commit/23ab82b5d26dad0db14817ae3841cf637dddcf5c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Assignee: nobody → jgriffin
(Assignee)

Updated

5 years ago
Blocks: 841091
(Assignee)

Updated

5 years ago
Blocks: 841128
You need to log in before you can comment on or make changes to this bug.