841093 - [traceback] AttributeError: 'NoneType' object has no attribute 'find'

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace.firefox.com/developers/submit/app/manifest
2. Validate http://m.facebook.com/openwebapp/manifest.webapp


observed behavior:
ugly traceback!

traceback details:
 Stack trace in text:

Traceback (most recent call last):
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/tasks.py",
line 55, in validator
    validation_result = run_validator(upload.path)
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/tasks.py",
line 119, in run_validator
    market_urls=settings.VALIDATOR_IAF_URLS)
  File
"/data/www/addons.mozilla.org/venv/src/app-validator/appvalidator/validate.
py",
line 37, in validate_app
    submain.test_inner_package(bundle, None)
  File
"/data/www/addons.mozilla.org/venv/src/app-validator/appvalidator/submain.p
y",
line 113, in test_inner_package
    test(err, package)
  File
"/data/www/addons.mozilla.org/venv/src/app-validator/appvalidator/testcases
/webappbase.py",
line 288, in test_app_resources
    max_size=False)
  File
"/data/www/addons.mozilla.org/venv/src/app-validator/appvalidator/testcases
/webappbase.py",
line 93, in try_get_resource
    url = _normalize_url(err, url)
  File
"/data/www/addons.mozilla.org/venv/src/app-validator/appvalidator/testcases
/webappbase.py",
line 55, in _normalize_url
    p_defurl = urlparse.urlparse(err.get_resource("manifest_url"))
  File "/usr/lib64/python2.6/urlparse.py", line 129, in urlparse
    tuple = urlsplit(url, scheme, allow_fragments)
  File "/usr/lib64/python2.6/urlparse.py", line 168, in urlsplit
    i = url.find(':')
AttributeError: 'NoneType' object has no attribute 'find'



NOTE:
on -dev, I don't see this traceback. I see an error associated with icon file. See https://marketplace-dev.allizom.org/developers/upload/6cac399d0f8b490d98af57aa25e0ddc9

The icon file looks valid to me.

Comment 1

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/16e72d5490c2a913c6519f819ff41945fdf010a3