841135 - Remove marketplace test cert

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #822944 +++
+++ This bug was initially created as a clone of Bug #772365 +++

In bug 822944, we will add the marketplace production cert. In this bug, we will remove the test cert. There will be a short period of time when both certificates are trusted, to maximize the flexibility in doing the migration on the server side.

Comment 1

[Jason Smith [:jsmith]]

Same rationale as - https://bugzilla.mozilla.org/show_bug.cgi?id=822944#c14. We aren't getting this done by 2/28.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Jason Smith [:jsmith] from comment #1)
> Same rationale as - https://bugzilla.mozilla.org/show_bug.cgi?id=822944#c14.
> We aren't getting this done by 2/28.

Making tef? so that we can either decide this is not a blocker, or know we missed the deadline.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > Same rationale as - https://bugzilla.mozilla.org/show_bug.cgi?id=822944#c14.
> > We aren't getting this done by 2/28.
> 
> Making tef? so that we can either decide this is not a blocker, or know we
> missed the deadline.

We basically have to do this. Leaving this in creates a problem where we can allow privileged apps with the test cert, which is a security problem.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Then I'm confused - the comment 3 says "we aren't getting this done by 2/28", and the comment 5 says "we basically have to do this".  Which one is it?

Comment 5

[Jason Smith [:jsmith]]

(In reply to Milan Sreckovic [:milan] from comment #4)
> Then I'm confused - the comment 3 says "we aren't getting this done by
> 2/28", and the comment 5 says "we basically have to do this".  Which one is
> it?

Both. We can't do it by 2/28 because of MWC demos using marketplace signed packaged apps. We have do this for the reasons mentioned in comment 3.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, you're assuming that we can miss the 2/28 deadline and still have the code show up in the build.  That may very well end up happening, but it's dangerous to get used to that. When would it get done?

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Milan Sreckovic [:milan] from comment #6)
> OK, you're assuming that we can miss the 2/28 deadline and still have the
> code show up in the build.  That may very well end up happening, but it's
> dangerous to get used to that. When would it get done?

This was already discussed on b2g-release-drivers. I agree it is bad but it is a special case. I suggest we keep discussing it in b2g-release-drivers if we are worried about it.

Comment 8

[Alex Keybl [:akeybl]]

(In reply to Jason Smith [:jsmith] from comment #5)
> (In reply to Milan Sreckovic [:milan] from comment #4)
> > Then I'm confused - the comment 3 says "we aren't getting this done by
> > 2/28", and the comment 5 says "we basically have to do this".  Which one is
> > it?
> 
> Both. We can't do it by 2/28 because of MWC demos using marketplace signed
> packaged apps. We have do this for the reasons mentioned in comment 3.

Jason called out this risk ahead of 2/28. We'll leave this on tef+ and call out the fact that this work isn't yet complete in our rollup to partners.

Comment 9

[Jason Smith [:jsmith]]

Wil mentions he'll be targeting getting the resigning of packaged apps done with the production cert by this Thursday. If all goes to plan and nothing blows up, we should target a fix for this on Friday - 3/8/2013.

Comment 10

[Andrew Overholt [:overholt]]

(In reply to Jason Smith [:jsmith] from comment #9)
> Wil mentions he'll be targeting getting the resigning of packaged apps done
> with the production cert by this Thursday. If all goes to plan and nothing
> blows up, we should target a fix for this on Friday - 3/8/2013.

Did things go as planned?

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Andrew Overholt [:overholt] from comment #10)
> (In reply to Jason Smith [:jsmith] from comment #9)
> > Wil mentions he'll be targeting getting the resigning of packaged apps done
> > with the production cert by this Thursday. If all goes to plan and nothing
> > blows up, we should target a fix for this on Friday - 3/8/2013.
> 
> Did things go as planned?

Yessir, packaged apps were resigned with the new cert and installed successfully on the device.

Comment 12

[Andrew Overholt [:overholt]]

Awesome, sounds like we're ready to remove the test cert now?

Comment 13

[Wil Clouser [:clouserw]]

thumbs up from me

Comment 14

[Andrew Overholt [:overholt]]

Brian, are you still the best assignee here?

Comment 15

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Remove trust from the Firefox Marketplace test cert

Honza, in another bug I added the production cert and left the test cert, to facilitate the transition from the test cert to the production cert. This bug is about removing the test cert so that we only trust the production cert.

Comment 16

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34ca09eff02d
https://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d9d5c368179b

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34ca09eff02d