841145 - MOZ_SHUTDOWN_CHECKS to control what we do with late writes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

With this patch an addon author should be able to debug its addon with a released version of firefox by setting MOZ_SHUTDOWN_CHECKS to "crash" (to use a debugger) or "record" (to just look in about:telemetry).

Comment 1

[Vladan Djeric (:vladan)]

Comment on attachment 713592 [details] [diff] [review]
patch

>+    // We normally don't poison writes if gShutdownChecks is SCM_NOTHING, but
>+    // write poisoning can get more users in the future (profiling for example),
>+    // so make sure we behave correctly.
>+    if (gShutdownChecks == SCM_NOTHING || ok || !sProfileDirectory ||
>+        !Telemetry::CanRecord())
>         return ok;

Add a curly for this please

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/049392b28dd1

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/049392b28dd1