Closed
Bug 84115
Opened 24 years ago
Closed 24 years ago
nsIProcess on windows ignore arguments
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: slogan, Assigned: slogan)
Details
(Whiteboard: MUST HAVE; patch; r=ssu/sgehani; sr=?)
Attachments
(1 file)
|
4.56 KB,
patch
|
Details | Diff | Splinter Review |
Ok, I blew it. A fix last week (80282) broke some installed XPIs because it
dropped process arguments passed into the run function on the floor. I'll be
attaching a patch to fix this.
This *has* to get into 0.9.1. Attaching patches, already tested and reviewed by
ssu.
For netscapers, see also 5874, the bug that depends on this one getting fixed
|
||
Comment 4•24 years ago
|
||
r=sgehani as well.
|
||
Updated•24 years ago
|
Whiteboard: MUST HAVE; patch; r=ssu/sgehani; sr=?
|
||
Comment 5•24 years ago
|
||
sr=mscott
|
||
Comment 6•24 years ago
|
||
Where is |cmdLine| freed?
Have you thought about using the string classes to avoid a large upfront buffer
allocation?
It seams to me that this kind of logic should be hidden in nsLocalFileWin. Does
passing mTargetPath.get() just not work?
What in 80282 broke argument passing?
Talked to dougt, he understands this is nspr code copied over for the time being
and that modifying it would intro risk.
|
||
Comment 8•24 years ago
|
||
a= asa@mozilla.org for checkin to the 0.9.1 branch.
(on behalf of drivers)
Fixed trunk and branch
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Comment 10•24 years ago
|
||
verified code fix
bug 5874 is v/f also
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•