841154 - No sample labels for image decoding

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We're trying to evaluate a memory/decode tradeoff for bug 840910.  To do so, it would help tremendously if we could see image decoding cost nicely ordered in the gecko profiler.  Right now it's all a garbled mess.

http://people.mozilla.com/~bgirard/cleopatra/#report=4ab8c2cbc0e5bd197334abf942c2a4fcaa0f967e

Pointers on where to toss SAMPLE_LABEL()s to see into the darkness?

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I don't know what a SAMPLE_LABEL is but Decoder::Write is probably what you want.

Comment 2

[Justin Lebar (not reading bugmail)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #1)
> I don't know what a SAMPLE_LABEL is

It pushes a entry onto the builtin profiler's pseudostack.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Add a sample label for image decoding

Thanks gents, looks like this does the job.

http://people.mozilla.com/~bgirard/cleopatra/#report=43dcc3414c6eeb6e613840ba74eebdda099a172a

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 713616 [details] [diff] [review]
Add a sample label for image decoding

Review of attachment 713616 [details] [diff] [review]:
-----------------------------------------------------------------

I'm amused that you tagged me after I said I didn't know what this did :-P

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

jlebar explained ;).

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3970a39cc25

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3970a39cc25