Closed Bug 841215 Opened 9 years ago Closed 9 years ago

Change - Ensure selected tab thumbnail is visible when opening tab app bar

Categories

(Tracking Graveyard :: Metro Operations, defect, P1)

x86
Windows 8
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jbecerra, Assigned: fryn)

References

Details

(Whiteboard: feature=change c=Tabs_app_bar u=metro_firefox_user p=3 status=verified)

Attachments

(1 file)

Tested on 2013-02-13 Nightly built from http://hg.mozilla.org/project/elm/rev/b3e65fe37681

You can have multiple tabs open and if you happen to glance at the tab strip and you scroll the focused tab thumbnail past the view, and dismiss the strip, going back can be a little confusing because you need to scroll left or right to find it.

Maybe the focused tab should always come up visible in the strip if you happen to go back to the strip after scrolling it out of view.
Priority: -- → P4
See Also: → 831927
Whiteboard: feature=change
Whiteboard: feature=change
Yes, you are right Juan. I thought that's what I specified in the story but I realize the story might not have been clear. Let's treat this like a change. When opening the tab strip, the focused tab should be in the visible area and if that means the strip has to scroll, then it should scroll.
Blocks: 831927
No longer blocks: metrov1triage
Whiteboard: feature=change
Blocks: metrov1it3
No longer blocks: 831927
Summary: scrolling focused tab thumbnail past the visible strip can be confusing → Change - scrolling focused tab thumbnail past the visible strip can be confusing
Priority: P4 → P1
Blocks: 831927
Whiteboard: feature=change → feature=change c=Tabs_app_bar u=metro_firefox_user p=0
Assignee: nobody → fyan
Status: NEW → ASSIGNED
Whiteboard: feature=change c=Tabs_app_bar u=metro_firefox_user p=0 → feature=change c=Tabs_app_bar u=metro_firefox_user p=3
Summary: Change - scrolling focused tab thumbnail past the visible strip can be confusing → Change - Ensure selected tab thumbnail is visible when opening tab app bar
Attached patch patchSplinter Review
I tried to add the handler as a <handler/>, but I guess the event doesn't bubble or something, so I did this instead.

Also, MozContextUIExpand is called both when closing and opening the tab app bar, but this particular handler should only be called when opening the tab strip. It's not a big deal though, and we can revisit this later when the overall UI is more finalized.
Attachment #718171 - Flags: review?(mbrubeck)
Attachment #718171 - Flags: review?(mbrubeck) → review+
Added removeEventListener in a destructor to be safe (following the pattern used in all the other browser/metro/ bindings).

https://hg.mozilla.org/integration/mozilla-inbound/rev/743eb982010a
Target Milestone: --- → Firefox 22
https://hg.mozilla.org/mozilla-central/rev/743eb982010a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(jbecerra)
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Target Milestone: Firefox 22 → ---
Version: Trunk → ---
Tested on 2013-02-28 with a nightly build from http://hg.mozilla.org/mozilla-central/rev/c65d59d33aa8
- When I scroll the tab strip beyond the point where the focused tab is, and I dismiss the strip, going back will show me the focused tab highlighted.
- The focused tab will be shown on the left or right, and highlighted, depending on how I scrolled the strip.
- Also tried restarting the browser, having setup "remember tabs from last time", just for kicks, and this still works as expected.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Whiteboard: feature=change c=Tabs_app_bar u=metro_firefox_user p=3 → feature=change c=Tabs_app_bar u=metro_firefox_user p=3 status=verified
I can not understand steps to test this. Can any one provide steps to test this?
Flags: needinfo?(jbecerra)
Steps to reproduce/test:
1. Open a large number of tabs, so the tab strip becomes scrollable.
2. Scroll the tab strip so the selected tab is no longer visible.
3. Dismiss the tab strip.
4. Open the tab strip again.

Expected results: The selected tab is visible again after step 4.
Flags: needinfo?(jbecerra)
(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> Steps to reproduce/test:
> 1. Open a large number of tabs, so the tab strip becomes scrollable.
> 2. Scroll the tab strip so the selected tab is no longer visible.
> 3. Dismiss the tab strip.
> 4. Open the tab strip again.
> 
> Expected results: The selected tab is visible again after step 4.

Thanks Matt.

User Agent:Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:25.0) Gecko/20130724 Firefox/25.0
Build ID: 20130724030204

WFM.

Tested on Windows 8.1 preview for iteration 10 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/2983ca6d4d1a

I followed steps provided in comment 7 and got expected result.
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly  for iteration-11. Followed steps provided in comment7 and got expected result.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment7 and got expected result.
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.