Add Open Link in Private Window context menuitem

RESOLVED FIXED in seamonkey2.18

Status

SeaMonkey
UI Design
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

unspecified
seamonkey2.18
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Also hide the "Open Link in New Window" menuitem in private windows.
(Assignee)

Comment 1

4 years ago
Created attachment 713827 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #713827 - Flags: review?(philip.chee)
(Assignee)

Updated

4 years ago
Attachment #713827 - Flags: review?(iann_bugzilla)

Comment 2

4 years ago
Comment on attachment 713827 [details] [diff] [review]
Proposed patch

Thu Feb 14 2013 21:37:06
Error: ReferenceError: openNewPrivateWith is not defined
Source file: chrome://communicator/content/nsContextMenu.js
Line: 755
Attachment #713827 - Flags: review?(philip.chee)
(Assignee)

Comment 3

4 years ago
Comment on attachment 713827 [details] [diff] [review]
Proposed patch

Please apply patches from unresolved dependent bugs before reviewing, thanks!
Attachment #713827 - Flags: review?(philip.chee)

Comment 4

4 years ago
Comment on attachment 713827 [details] [diff] [review]
Proposed patch

> -                oncommand="gContextMenu.openLink();"/>
> +                oncommand="gContextMenu.openLinkInWindow();"/>
> +      <menuitem id="context-openlinkprivate"
> +                label="&openLinkCmdPrivate.label;"
> +                accesskey="&openLinkCmdPrivate.accesskey;"
This should probably be:
openLinkInPrivateWindowCmd.label and openLinkInPrivateWindowCmd.accesskey .

> +                oncommand="gContextMenu.openLinkInPrivate();"/>
gContextMenu.openLinkInPrivateWindow()

> +  // Open linked-to URL in a private window.
> +  openLinkInPrivate: function() {
openLinkInPrivateWindow:

> +<!ENTITY openLinkCmdPrivate.label     "Open Link in Private Window">
> +<!ENTITY openLinkCmdPrivate.accesskey "d">
This access key conflicts with "Sen_d_ This Page".
(Assignee)

Comment 5

4 years ago
(In reply to Philip Chee from comment #4)
> openLinkInPrivateWindowCmd.label and openLinkInPrivateWindowCmd.accesskey .
Far too long.

> > +                oncommand="gContextMenu.openLinkInPrivate();"/>
> gContextMenu.openLinkInPrivateWindow()
Actually I see I should have called it openLinkPrivate().

> > +<!ENTITY openLinkCmdPrivate.accesskey "d">
> This access key conflicts with "Sen_d_ This Page".
Bah, I thought I'd checked everything :-(
(Assignee)

Comment 6

4 years ago
(In reply to comment #5)
> (In reply to Philip Chee from comment #4)
> > > +<!ENTITY openLinkCmdPrivate.accesskey "d">
> > This access key conflicts with "Sen_d_ This Page".
> Bah, I thought I'd checked everything :-(
Oh, different overlay, no wonder I overlooked it...
(Assignee)

Comment 7

4 years ago
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to Philip Chee from comment #4)
> > > > +<!ENTITY openLinkCmdPrivate.accesskey "d">
> > > This access key conflicts with "Sen_d_ This Page".
> > Bah, I thought I'd checked everything :-(
> Oh, different overlay, no wonder I overlooked it...
And of course my actual testing had been done with a linked image, on which Send This Page is already hidden. Any objections to hiding it for all links?

Comment 8

4 years ago
>> gContextMenu.openLinkInPrivateWindow()
> Actually I see I should have called it openLinkPrivate().
OK you can keep the shorter names.

>>> Bah, I thought I'd checked everything :-(
>> Oh, different overlay, no wonder I overlooked it...
> And of course my actual testing had been done with a linked image, on which Send This
> Page is already hidden. Any objections to hiding it for all links?
No objections, sounds reasonable to me.
(Assignee)

Comment 9

4 years ago
Created attachment 714348 [details] [diff] [review]
Revised patch
Attachment #713827 - Attachment is obsolete: true
Attachment #713827 - Flags: review?(philip.chee)
Attachment #713827 - Flags: review?(iann_bugzilla)
Attachment #714348 - Flags: review?(philip.chee)
Attachment #714348 - Flags: review?(iann_bugzilla)

Comment 10

4 years ago
I think "O" is still available.
(Assignee)

Comment 11

4 years ago
(In reply to Philip Chee from comment #10)
> I think "O" is still available.
Used to block a popup, if you allowed it by mistake.

Comment 12

4 years ago
Comment on attachment 714348 [details] [diff] [review]
Revised patch

Looks good. r=me
Attachment #714348 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 13

4 years ago
Pushed comm-central changeset 447443b87c8e.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → seamonkey2.18

Updated

4 years ago
Attachment #714348 - Flags: review?(iann_bugzilla) → review+

Updated

4 years ago
Depends on: 856587
(Assignee)

Updated

4 years ago
Depends on: 860905
You need to log in before you can comment on or make changes to this bug.