Followup fix for the captive portal changes

VERIFIED FIXED in Firefox 21

Status

defect
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: fabrice, Assigned: fabrice)

Tracking

unspecified
B2G C4 (2jan on)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:shira+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
blocking-b2g: --- → shira+
Depends on: 752982
Posted patch patch (obsolete) — Splinter Review
I still don't understand how that can work since we don't set the URL of the page to ping to something meaningful.
Assignee: nobody → fabrice
(In reply to Fabrice Desré [:fabrice] from comment #1)
> Created attachment 713733 [details] [diff] [review]
> patch
> 
> I still don't understand how that can work since we don't set the URL of the
> page to ping to something meaningful.
Hi, we haven't decide whether Mozilla or our partners should be responsible for hosting the page. For the internal testing, we can override the canonical URL and content with following parameters in user prefs at runtime.
user_pref("services.captivedetect.canonicalURL", "http://people.mozilla.org/~schien/test.txt");
user_pref("services.captivedetect.canonicalContent", "true\n");
Then we should rather not set the pref at all in the default case, and bail out cleanly when there is no such pref.
Attachment #713733 - Flags: review?(schien)
Comment on attachment 713733 [details] [diff] [review]
patch

Review of attachment 713733 [details] [diff] [review]:
-----------------------------------------------------------------

r+ since this patch is simply changing the name of compile option.
Attachment #713733 - Flags: review?(schien) → review+
1. compile option change to MOZ_CAPTIVEDETECT
2. contract id change to @mozilla.org/toolkit/captive-detector;1
Attachment #713733 - Attachment is obsolete: true
Attachment #714437 - Flags: review?(vchang)
Attachment #714437 - Flags: review?(timdream)
Attachment #714437 - Flags: review?(vchang)
Attachment #714437 - Flags: review?(timdream)
Attachment #714437 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4df76fa12f0a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: QARegressExclude
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.