841243 - Followup fix for the captive portal changes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

I still don't understand how that can work since we don't set the URL of the page to ping to something meaningful.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Fabrice Desré [:fabrice] from comment #1)
> Created attachment 713733 [details] [diff] [review]
> patch
> 
> I still don't understand how that can work since we don't set the URL of the
> page to ping to something meaningful.
Hi, we haven't decide whether Mozilla or our partners should be responsible for hosting the page. For the internal testing, we can override the canonical URL and content with following parameters in user prefs at runtime.
user_pref("services.captivedetect.canonicalURL", "http://people.mozilla.org/~schien/test.txt");
user_pref("services.captivedetect.canonicalContent", "true\n");

Comment 3

[[:fabrice] Fabrice Desré]

Then we should rather not set the pref at all in the default case, and bail out cleanly when there is no such pref.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 713733 [details] [diff] [review]
patch

Review of attachment 713733 [details] [diff] [review]:
-----------------------------------------------------------------

r+ since this patch is simply changing the name of compile option.

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: update compile option and contract id accroding to the change in bug 752982

1. compile option change to MOZ_CAPTIVEDETECT
2. contract id change to @mozilla.org/toolkit/captive-detector;1

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4df76fa12f0a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4df76fa12f0a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/7dd8805b692d
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/fce6e0f61782