841261 - nsFrameIterator constructor should use init list to initialize its variables

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

https://mxr.mozilla.org/mozilla-central/source/layout/base/nsFrameTraversal.cpp#186

The nsFrameIterator constructor should use an init list instead of assignments in the constructor.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

NOTES:

I moved this reassignment...
  aStart = nsPlaceholderFrame::GetRealFrameFor(aStart);
...up one level, so that we don't have to worry about fixing up aStart in the constructor.  (And I added an assertion in the constructor to verify that this has been done.)

I also marked a bunch of member-vars as 'const' (which we can do now that they're set via the init list), and removed two unused setters (since I've now marked the variable they attempt to set as being const).

Comment 2

[Daniel Holbert [:dholbert]]

This doesn't bitrot bug 242829's patch, BTW -- MQ still happily applies it (with a mention that it's used fuzz 1 to do so).

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e92ba60695d

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/4e92ba60695d