Closed Bug 841354 Opened 11 years ago Closed 1 month ago

Some of the buttons have a subtle focus ring

Categories

(DevTools :: Framework, defect)

x86
All
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: sbadau, Unassigned)

Details

Attachments

(1 file)

Attached video Screencast
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130214 Firefox/21.0
Build ID: 20130214032850

Please see the screencast for more details.

Steps to reproduce:
1. Launch Firefox 
2. Open the Debugger -> click on the Step Over button

Expected results:
The button has no focus ring.

Actual results:
The button has a subtle focus ring.

Note:
The issue is intermittently reproducible on Windows 7 but it is reproducible every time on Ubuntu 12.10.

Reproducible also on the latest Nightly, Aurora and Firefox 19 beta.
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130214 Firefox/21.0 
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130213 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20100101 Firefox/19.0 (20130212082553) - used the debugger because the Toolbox is not available on Firefox 19.
I'll try to find the regression range as soon as possible.
> Expected results:
> The button has no focus ring.

Why? We draw this focus ring in purpose.
even though we do this on purpose, when some clicks a button with mouse and the focus ring appears, it looks weird and broken.

As far as I know, the new downloads panel's items also have focus rings and they only appear with using keyboard. That is also what was discussed in bug 819428 and related bugs that focus rings should not appear when using via mouse.
Dropping this down to trivial since this is only cosmetic; it does not seem to impact functionality whatsoever.
Severity: normal → trivial
(In reply to Girish Sharma [:Optimizer] from comment #3)
> even though we do this on purpose, when some clicks a button with mouse and
> the focus ring appears, it looks weird and broken.

You need to explain that. It doesn't look weird and broken to me.

Marking as INVALID as this has been designed in purpose and asked by a browser peer.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
The main thoughts and discussion is starting from this comment [1] and in bug 829495.

In short, the focus ring should not be visible until the user has used keyboard for the first time. For example, If I click the Resume button, the focus ring should not be there, but then if I press Tab which actually brings focus to the next button that is Step Over button, the focus ring should appear.

The issue that is described in this bug is that the focus ring is appearing even if the button was clicked for the first time using mouse. Although I cannot reproduce the same every time, I can intermittently see that sometimes, when I click a button, the focus ring appears.

Not changing the status until I have some solid STR.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=819428#c7
Ah well, first comment says that its intermittent on Windows 7 and always on Ubuntu.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
> If I click the Resume button, the focus ring should not be there

Why?
(In reply to Paul Rouget [:paul] from comment #8)
> > If I click the Resume button, the focus ring should not be there
> 
> Why?

I am using mouse, so I do not need to know where the focus is. The whole browser UI is like this, no button has a focus ring when you click on it. Then why this ?
Product: Firefox → DevTools
Severity: trivial → S4

Closing since this is not reproducible anymore using latest Firefox 123.0 build.

Status: REOPENED → RESOLVED
Closed: 11 years ago1 month ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: