Closed
Bug 841366
Opened 12 years ago
Closed 10 years ago
[l10n][Gallery] Button to set an image as wallpaper from gallery has not enough space to shown the string in many locales
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(b2g-v1.4 affected, b2g-v2.0 affected, b2g-v2.1 verified)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: carlosmartinez, Assigned: theo)
References
Details
(Keywords: l12y, Whiteboard: LocRun1.4, LocRun2.0)
Attachments
(2 files)
STR:
1-Open gallery app
2-Select a pic
3-Open share menu
4-Select wallpaper
Expected result --> button in the right shows a text that fits the available space
Actual result --> button in the right shows: "Usar como fondo d..."
Assignee | ||
Comment 1•11 years ago
|
||
Other locales are affected, like pt-BR, fr, de, for instance. For French we really can’t shorter the string. We will need UX input on this bug.
My proposal is to automatically reduce the size of the Cancel for locales that need to.
Flags: needinfo?(firefoxos-ux-bugzilla)
Assignee | ||
Updated•11 years ago
|
Blocks: 892075
Summary: [l10n][Spanish][Gallery] Button to set an image as wallpaper from gallery has not enough space to shown the string → [l10n][Gallery] Button to set an image as wallpaper from gallery has not enough space to shown the string in many locales
Comment 2•11 years ago
|
||
Assigning to Peter to advise on button size. Peter, please reassign as necessary. If the button size cannot be adjust, please needinfo? Matej Novak to advise on copy changes.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(pla)
Hi Stephany,
Can we get access to the full set of strings for every language? We'll need to know the exact string lengths to be able to properly design to accomodate them.
Looping in Eric, who may have dealt with this type of issue recently.
Flags: needinfo?(pla) → needinfo?(epang)
Comment 4•11 years ago
|
||
Flagging Delphine to see if she might know about the full sets of strings. Delphine, Peter is part of the group of UXers working to fix localization bugs. Thanks!
Flags: needinfo?(lebedel.delphine)
Comment 5•11 years ago
|
||
(In reply to Peter La from comment #3)
> Hi Stephany,
>
> Can we get access to the full set of strings for every language? We'll need
> to know the exact string lengths to be able to properly design to accommodate
> them.
>
> Looping in Eric, who may have dealt with this type of issue recently.
Hi Peter, IMO I don't think it needs to say "Set as wallpaper". Can it be changed to be "Set"? Because at this stage the user should be aware they are setting their phone's wallpaper. Or it might even make sense to add the text "Set as wallpaper" in the share menu (since there's more room for the string) and change the button on the following screen to "Set". What do you think?
Flags: needinfo?(epang)
Comment 6•11 years ago
|
||
Sorry this has bounced off my radar...
I believe that for English, you can find these strings here: https://hg.mozilla.org/gaia-l10n/en-US/file/c244ecf7abbe/apps/wallpaper/wallpaper.properties
for other locales, just navigate to https://hg.mozilla.org/gaia-l10n/ then choose the locale you want, then go to apps, wallpaper, and wallpaper.properties
Flags: needinfo?(lebedel.delphine)
Comment 7•11 years ago
|
||
Updating keywords: not late-l10n, but definitely l12y.
Assignee | ||
Updated•10 years ago
|
Whiteboard: LocRun1.4
status-b2g-v1.4:
--- → affected
Comment 11•10 years ago
|
||
This issue reproduces for Swahili following the STR listed in Comment 0.
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.0:
--- → affected
Flags: needinfo?(ktucker)
Whiteboard: LocRun1.4 → LocRun1.4, LocRun2.0
Comment 12•10 years ago
|
||
This issue reproduces for Tamil in 2.0 Flame with the STR listed in Comment 0.
Environmental Variables:
Device: Flame 2.0
BuildID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Assignee | ||
Comment 13•10 years ago
|
||
Hi Peter,
Is Eric's suggestion in Comment 5 about shortening the string to "Set" okay for you?
Flags: needinfo?(pla)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Comment 14•10 years ago
|
||
Hi Eric and Theo.
Yes, I agree with Eric. While 'Set as Wallpaper' is still more explicit, the user will have already hit 'Share' -> 'Wallpaper', so the context is already clear.
Recommendation: on the button, change 'Set as wallpaper' to 'Set'
As for the action menu, I would leave it as 'Wallpaper' because the the action menu title is 'Share with:", and "Set as Wallpaper" wouldn't make grammatical sense.
Thanks!
Flags: needinfo?(pla)
Assignee | ||
Comment 15•10 years ago
|
||
Thanks Peter, let's do that
Comment 16•10 years ago
|
||
Comment on attachment 8453200 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21422
Passing review to a Gallery peer
Attachment #8453200 -
Flags: review?(dale) → review?(dwilson)
Comment 17•10 years ago
|
||
Comment on attachment 8453200 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21422
I think you intended to pass it on to Diego Marcos
Attachment #8453200 -
Flags: review?(dwilson) → review?(dmarcos)
Comment 18•10 years ago
|
||
Comment on attachment 8453200 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21422
Sending this to djf
Attachment #8453200 -
Flags: review?(dmarcos) → review?(dflanagan)
Comment 19•10 years ago
|
||
Comment on attachment 8453200 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21422
Looks good!
Attachment #8453200 -
Flags: review?(dflanagan) → review+
Comment 21•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
Comment 22•10 years ago
|
||
This issue has been successfully verified on Flame 2.1
See attachment: 1.png
Reproducing rate: 0/5
Flame 2.1 new build:
Gaia-Rev db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID 20141126001202
Version 34.0
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•