841404 - Sequence<>-dependency to dictionary in same .webidl file sometimes generates in wrong order, causing compiler ref-error

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

See Bug 835712, comment 4. The second patch in that bug (also linked here in URL) causes this try burn: https://tbpl.mozilla.org/?tree=Try&rev=44d2473d9f4d

What's disturbing is that when I built it locally, it failed initially, but after a few edits and weak attempts at workarounds, it suddenly built fine. I removed my workaround attempts and it still built fine. I rebuilt it on inbound as opposed to central where I had it and it still built fine. It was only when I did a try that it failed.

I suspect it sometimes generates in the correct order and sometimes in the wrong order, which makes it easy to burn the tree by mistake.

The relevant part of that log:

  In file included from
  ../media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:46:
  ../dist/include/mozilla/dom/RTCConfigurationBinding.h:31:23: error:
    use of undeclared identifier 'RTCIceServer'
  Optional< Sequence< RTCIceServer > > mIceServers;
                      ^
  ../dist/include/mozilla/dom/RTCConfigurationBinding.h:31:38: error:
    expected a type
  Optional< Sequence< RTCIceServer > > mIceServers;
                                     ^
2 errors generated.

The relevant part of dom/webidl/RTCConfiguration.webidl:

  dictionary RTCIceServer {
      DOMString  url;
      DOMString? credential = null;
  };

  dictionary RTCConfiguration {
      sequence<RTCIceServer> iceServers;
  };

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Here's the relevant OS X 10.7 opt log entry: https://tbpl.mozilla.org/php/getParsedLog.php?id=19728758&tree=Try

Comment 2

[Boris Zbarsky [:bzbarsky]]

Looks like something I forgot to handle in bug 790975.

And you're right that the ordering is currently semi-random: there's a Python set() involved.  :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure that we treat dictionaries inside sequence and array members of a dictionary as dependencies for it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Jan-Ivar, does that patch help?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Works! https://tbpl.mozilla.org/?tree=Try&rev=c3261e15bb78

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I was hoping to land my constraints patch, bug 835370, before Tuesday but it is blocked by this. Any chance of it landing soon?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Needs review from Peter.  With any luck, that'll happen Monday; if so feel free to push this with your patch if I haven't gotten to it first!

Comment 8

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/046df99b88b0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/046df99b88b0