Closed
Bug 841404
Opened 11 years ago
Closed 11 years ago
Sequence<>-dependency to dictionary in same .webidl file sometimes generates in wrong order, causing compiler ref-error
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jib, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
See Bug 835712, comment 4. The second patch in that bug (also linked here in URL) causes this try burn: https://tbpl.mozilla.org/?tree=Try&rev=44d2473d9f4d What's disturbing is that when I built it locally, it failed initially, but after a few edits and weak attempts at workarounds, it suddenly built fine. I removed my workaround attempts and it still built fine. I rebuilt it on inbound as opposed to central where I had it and it still built fine. It was only when I did a try that it failed. I suspect it sometimes generates in the correct order and sometimes in the wrong order, which makes it easy to burn the tree by mistake. The relevant part of that log: In file included from ../media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:46: ../dist/include/mozilla/dom/RTCConfigurationBinding.h:31:23: error: use of undeclared identifier 'RTCIceServer' Optional< Sequence< RTCIceServer > > mIceServers; ^ ../dist/include/mozilla/dom/RTCConfigurationBinding.h:31:38: error: expected a type Optional< Sequence< RTCIceServer > > mIceServers; ^ 2 errors generated. The relevant part of dom/webidl/RTCConfiguration.webidl: dictionary RTCIceServer { DOMString url; DOMString? credential = null; }; dictionary RTCConfiguration { sequence<RTCIceServer> iceServers; };
Reporter | ||
Comment 1•11 years ago
|
||
Here's the relevant OS X 10.7 opt log entry: https://tbpl.mozilla.org/php/getParsedLog.php?id=19728758&tree=Try
![]() |
Assignee | |
Comment 2•11 years ago
|
||
Looks like something I forgot to handle in bug 790975. And you're right that the ordering is currently semi-random: there's a Python set() involved. :(
![]() |
Assignee | |
Comment 3•11 years ago
|
||
Attachment #713943 -
Flags: review?(peterv)
Reporter | ||
Comment 5•11 years ago
|
||
Works! https://tbpl.mozilla.org/?tree=Try&rev=c3261e15bb78
Flags: needinfo?(jib)
Reporter | ||
Comment 6•11 years ago
|
||
I was hoping to land my constraints patch, bug 835370, before Tuesday but it is blocked by this. Any chance of it landing soon?
![]() |
Assignee | |
Comment 7•11 years ago
|
||
Needs review from Peter. With any luck, that'll happen Monday; if so feel free to push this with your patch if I haven't gotten to it first!
Updated•11 years ago
|
Attachment #713943 -
Flags: review?(peterv) → review+
![]() |
Assignee | |
Comment 8•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/046df99b88b0
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla21
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/046df99b88b0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•