841411 - Remove enablePrivilege from tests added in bug 790475

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Bobby Holley (:bholley)]

I was just grepping through the commit log, and it appears that bug 790475 added some usage of enablePrivilege. That API is dangerous and deprecated, and per jst's decree new code may not add usage of enablePrivilege. The replacement API is SpecialPowers. :-)

Mike, can you fix the test?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Sure, on it.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Mike Conley (:mconley) from comment #1)
> Sure, on it.

Awesome, thanks :-)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Uses SpecialPowers instead of enablePrivilege("UniversalXPConnect").

Comment 4

[(no longer active)]

Comment on attachment 713947 [details] [diff] [review]
Patch v1

Review of attachment 713947 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/tests/test_bug790475.html
@@ +32,5 @@
> +  var editingSession = SpecialPowers.wrap(window)
> +                         .QueryInterface(Ci.nsIInterfaceRequestor)
> +                         .getInterface(Ci.nsIWebNavigation)
> +                         .QueryInterface(Ci.nsIInterfaceRequestor)
> +                         .getInterface(Ci.nsIEditingSession);

Please fix indentation.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1 - r+'d by ehsan

Good call - thanks.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5720e459a54

Comment 7

[:Cykesiopka]

https://hg.mozilla.org/mozilla-central/rev/e5720e459a54