Closed
Bug 841413
Opened 11 years ago
Closed 11 years ago
Per-Window Private browsing tests use enablePrivilege
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 22
People
(Reporter: bholley, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
2.94 KB,
patch
|
jdm
:
review+
ehsan.akhgari
:
checkin+
|
Details | Diff | Splinter Review |
4.69 KB,
patch
|
Details | Diff | Splinter Review |
Some of these have been added recently, but it's hard for me to tell whether they're just moves/copy-pastes from other tests or not. Either way, jdm said he'd find and owner, which makes me :-). toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html dom/tests/mochitest/localstorage/test_localStorageQuotaPrivateBrowsing_perwindowpb.html dom/tests/mochitest/localstorage/test_localStorageBasePrivateBrowsing_perwindowpb.htm
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
These are already chrome tests.
Attachment #717386 -
Flags: review?(josh)
Comment 3•11 years ago
|
||
Comment on attachment 717384 [details] [diff] [review] Convert test_privbrowsing_perwindowpb.html into a chrome test Review of attachment 717384 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/passwordmgr/test/Makefile.in @@ +86,5 @@ > + subtst_privbrowsing_2.html \ > + subtst_privbrowsing_3.html \ > + subtst_privbrowsing_4.html \ > + notification_common.js \ > + pwmgr_common.js \ Will pwmgr_common.js and notification_common.js still be available to plain mochitests?
Attachment #717384 -
Flags: review?(josh) → review+
Updated•11 years ago
|
Attachment #717386 -
Flags: review?(josh) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Josh Matthews [:jdm] from comment #3) > Comment on attachment 717384 [details] [diff] [review] > Convert test_privbrowsing_perwindowpb.html into a chrome test > > Review of attachment 717384 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: toolkit/components/passwordmgr/test/Makefile.in > @@ +86,5 @@ > > + subtst_privbrowsing_2.html \ > > + subtst_privbrowsing_3.html \ > > + subtst_privbrowsing_4.html \ > > + notification_common.js \ > > + pwmgr_common.js \ > > Will pwmgr_common.js and notification_common.js still be available to plain > mochitests? Sure, I didn't remove them from MOCHITEST_FILES, if that's what you mean...
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9ef1f1aa47d https://hg.mozilla.org/integration/mozilla-inbound/rev/917205c79822
00:18:43 INFO - 15426 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | uncaught exception - TypeError: normalWindowIframe is null at chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html:266
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 717386 [details] [diff] [review] Don't call enablePrivilege needlessly in localstorage PB tests https://hg.mozilla.org/integration/mozilla-inbound/rev/195e706140d1
Attachment #717386 -
Flags: checkin+
Assignee | ||
Updated•11 years ago
|
Whiteboard: [leave open]
Assignee | ||
Comment 9•11 years ago
|
||
Josh, any ideas about this test failure?
Updated•11 years ago
|
Target Milestone: --- → Firefox 22
Comment 11•11 years ago
|
||
This version passes for me.
Assignee | ||
Comment 12•11 years ago
|
||
Ship it!
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a14eaefe1d
Whiteboard: [leave open]
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e4a14eaefe1d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 15•11 years ago
|
||
(In reply to :Ehsan Akhgari from comment #13) > https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a14eaefe1d Backed out for test failures (the merge over to m-c was accidental on my part, I'll merge the backout over later). https://hg.mozilla.org/integration/mozilla-inbound/rev/f83e22300249 https://tbpl.mozilla.org/php/getParsedLog.php?id=20342039&tree=Mozilla-Inbound 07:48:51 INFO - 16033 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html 07:48:51 INFO - 16034 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | Access pwmgr 07:48:51 INFO - 16035 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | No logins should be stored for http://test2.example.com 07:48:52 INFO - 16036 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | uncaught exception - TypeError: normalWindowIframe is null at chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html:270 07:48:52 INFO - 16037 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | finished in 507ms 07:52:16 INFO - 32142 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul 07:52:18 INFO - 32143 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul | Download Manager wasn't closed 07:52:19 INFO - 32144 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul | Download Manager wasn't closed 07:52:20 INFO - 32145 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul | Download Manager wasn't closed 07:57:21 INFO - 32146 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul | Test timed out. 07:57:21 INFO - args: ['/home/cltbld/talos-slave/test/build/tests/bin/screentopng'] 07:57:21 INFO - SCREENSHOT: <see log> 07:57:22 INFO - 32147 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_on_last_window.xul | finished in 305476ms 07:57:23 INFO - 32148 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_delete_key_removes.xul 07:57:24 INFO - 32149 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_delete_key_removes.xul | Download Manager was closed 07:57:24 INFO - 32150 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_delete_key_removes.xul | [SimpleTest.finish()] this test already called finish! 07:57:24 INFO - 32151 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_delete_key_removes.xul | finished in 1286ms 07:57:24 INFO - 32152 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul 07:57:24 INFO - 32153 INFO TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | must wait for focus 07:57:24 INFO - 32154 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The database and the number of downloads display matches 07:57:25 INFO - 32155 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:25 INFO - 32156 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:25 INFO - 32157 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:25 INFO - 32158 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:26 INFO - 32159 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:26 INFO - 32160 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | The download was properly removed 07:57:26 INFO - 32161 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | chrome://mochitests/content/tests/SimpleTest/iframe-between-tests.html finished in a non-clean fashion, probably because it didn't call SimpleTest.finish() 07:57:26 INFO - 32162 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | finished in 1694ms
Assignee | ||
Comment 16•11 years ago
|
||
Josh, did you test this locally or on try?
Comment 17•11 years ago
|
||
Locally. I'm investigating.
Assignee | ||
Comment 18•11 years ago
|
||
(In reply to comment #17) > Locally. I'm investigating. Yeah for whatever reason this doesn't happen locally. I think we're relying on something that is there in an objdir but not in the test packages. Sorry, I thought I had mentioned this on the bug...
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 20•11 years ago
|
||
Updated•11 years ago
|
Attachment #719961 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #717384 -
Attachment is obsolete: true
Comment 22•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d9a2e95d50e8
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 23•11 years ago
|
||
Thanks a lot for your help here, Josh!
You need to log in
before you can comment on or make changes to this bug.
Description
•