nss_ctypes.py doesn't work in Mac

RESOLVED FIXED

Status

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: amac, Assigned: amac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR: 
1. Try to sign any app using the provided test script (security/manager/ssl/tests/unit/test_signed_apps/sign_b2g_app.py) on MacOS (tried on Darwin Kernel Version 12.2.0).
2. Python dies with a SIGSEGV error

Cause: 
Apparently, Python behaves differently on Darwin than it does either on Linux or on Windows, and it messes the return pointer from PL_strdup.
This fixes it for me. Setting the return value to *void makes Python not touch the pointer at all, apparently.
Attachment #713946 - Flags: review?(bsmith)
This has been pending of review for about 4 months... want me to assign it so somebody else?
Status: NEW → ASSIGNED
Flags: needinfo?(bsmith)
Attachment #713946 - Flags: review?(bsmith) → review+
Flags: needinfo?(bsmith)
https://hg.mozilla.org/mozilla-central/rev/5e11bb844eef
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.