841429 - passing optional integer arguments with default values in callback interface generates invalid code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

callback interface Foo {
void passOptionalByteWithDefault(optional byte arg = 0);
};

generates code like:

    if (arg.WasPassed()) {
      argv[0] = INT_TO_JSVAL(int32_t(arg.Value()));
      break;

where arg is int8_t

Comment 1

[Andrew McCreight [:mccr8]]

As you may guess, this also applies to the other integer types.

Comment 2

[Andrew McCreight [:mccr8]]

Also for at least one non-integer pattern this fails:

callback interface Foo {
  void passOptionalSelfWithDefault(optional Foo? arg = null);
};

with errors like: 

/Users/amccreight/mz/cent/obj-dbg/dom/bindings/JSImplBinding.cpp:35:12: error: member reference type 'mozilla::dom::Foo *' is a pointer; maybe you meant to use '->'?
    if (arg.WasPassed()) {
        ~~~^
           ->
/Users/amccreight/mz/cent/obj-dbg/dom/bindings/JSImplBinding.cpp:35:13: error: no member named 'WasPassed' in 'mozilla::dom::Foo'
    if (arg.WasPassed()) {
        ~~~ ^

Presumably basically the same thing...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix callback codegen for optional arguments with default values. change to enum wrapping is just to fix an indentation bug I ran into while reading the generated code for some of these test methods.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/592316b9ce80

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/592316b9ce80