make nsIDocShell inherit from nsIDocShellTreeItem

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

it should get rid of a number of qis.  we can't just merge them because nsWebBrowser wants to inherit from only nsIDocShellTreeItem
Comment on attachment 713985 [details] [diff] [review]
make nsIDocShell inherit from nsIDocShellTreeItem

r=me
Attachment #713985 - Flags: review?(bzbarsky) → review+
Comment on attachment 713986 [details] [diff] [review]
remove nolonger needed qi from nsIDocShell to nsIDocShellTreeItem

Quite lovely!
Attachment #713986 - Flags: review?(bzbarsky) → review+
Backed out for Windows bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8db0ae5853c1

https://tbpl.mozilla.org/php/getParsedLog.php?id=19748486&tree=Mozilla-Inbound

nsAccessNodeWrap.cpp

e:/builds/moz2_slave/m-in-w32-000000000000000000000/build/accessible/src/msaa/nsAccessNodeWrap.cpp(81) : error C2039: 'GetDocShellTreeItemFor' : is not a member of 'nsCoreUtils'

        e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\accessible\src\base\nsCoreUtils.h(29) : see declaration of 'nsCoreUtils'

e:/builds/moz2_slave/m-in-w32-000000000000000000000/build/accessible/src/msaa/nsAccessNodeWrap.cpp(81) : error C3861: 'GetDocShellTreeItemFor': identifier not found
I'm curious, what is the point of changing nsCoreUtils::GetDocShellTreeItemFor to GetDocShellFor?
(In reply to alexander :surkov from comment #7)
> I'm curious, what is the point of changing
> nsCoreUtils::GetDocShellTreeItemFor to GetDocShellFor?

I was hoping it would let me nuke more QI calls, but saddly it won't until bug 841430 when the do_GetInterface() stuff in HyperTextAccessible::GetEditor() should be able to go away.
https://hg.mozilla.org/mozilla-central/rev/f142fd877b48
https://hg.mozilla.org/mozilla-central/rev/e743d61ac764
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.