84145 - news: Sender searches containing @ will fail

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Henrik Gemal]

If you do a search for the following on a newsgroup on news.mozilla.org you get 
an NNTP_ERROR error in the NNTP log.

Search for:
Subject Contains .
Status Is Read
Sender Contains @

The NNTP log says:
0[344128]: creating a new nsNNTPProtocol(3237918)
0[344128]: initializing, so unset m_currentGroup
0[344128]: opening connection on nsNNTPProtocol(3237918)
0[344128]: to news.mozilla.org
0[344128]: on port 119
0[344128]: ParseURL
0[344128]: fullPath = /netscape.public.mozilla.directory?search/XPAT%20SUBJECT%
20%201-%20*.*/XPAT%20FROM%20%201-%20*@*
0[344128]: m_messageID = netscape.public.mozilla.directory?search/XPAT SUBJECT  
1- *.*/XPAT FROM  1- *@*
0[344128]: group = (null)
0[344128]: commandSpecificData = (null)
0[344128]: m_key = -1
0[344128]: Next state: NNTP_RESPONSE
0[344128]: Receiving: 200 secnews.netscape.com Netscape-Collabra/3.52 03615 
NNRP ready (posting ok).
0[344128]: Next state: NNTP_LOGIN_RESPONSE
0[344128]: Next state: NNTP_SEND_MODE_READER
0[344128]: Sending: MODE READER
0[344128]: Next state: NNTP_RESPONSE
0[344128]: Receiving: 200 secnews.netscape.com Netscape-Collabra/3.52 03615 
NNRP ready (posting ok).
0[344128]: Next state: NNTP_SEND_MODE_READER_RESPONSE
0[344128]: Next state: SEND_FIRST_NNTP_COMMAND
0[344128]: Sending: ARTICLE <netscape.public.mozilla.directory?search/XPAT 
SUBJECT  1- *.*/XPAT FROM  1- *@*>
0[344128]: Next state: NNTP_RESPONSE
0[344128]: Receiving: 501 [MessageID|Number]
0[344128]: Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
0[344128]: Next state: NNTP_ERROR
0[344128]: ClosingConnection on nsNNTPProtocol(3237918)
0[344128]: Sending: QUIT
0[344128]: Next state: NNTP_ERROR
0[344128]: ClosingConnection on nsNNTPProtocol(3237918)
0[344128]: Sending: QUIT
0[344128]: ClosingSocket() on nsNNTPProtocol(3237918)
0[344128]: CleanupAfterRunningUrl()
0[344128]: destroying nsNNTPProtocol(3237918)

Comment 1

[Henrik Gemal]

actually it was much simpler...
Just searching for
[Sender] [Contains] [@]

0[344128]: Next state: SEND_FIRST_NNTP_COMMAND
0[344128]: Sending: ARTICLE <netscape.public.mozilla.directory?search/XPAT 
FROM  1- *@*>
0[344128]: Next state: NNTP_RESPONSE
0[344128]: Receiving: 501 [MessageID|Number]
0[344128]: Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
0[344128]: Next state: NNTP_ERROR
0[344128]: ClosingConnection on nsNNTPProtocol(3237918)
0[344128]: Sending: QUIT
0[344128]: Next state: NNTP_ERROR
0[344128]: ClosingConnection on nsNNTPProtocol(3237918)
0[344128]: Sending: QUIT

Comment 2

[Håkan Waara]

I get a crash when doing that query. Will file a new bug.

Comment 3

[Håkan Waara]

bug 84301 filed. thanks Henrik for the testcase.

Comment 4

[(not reading, please use [e-mail] instead)]

working on the fix.  for fallout from some news code cleanup I did a while back.

Comment 5

[(not reading, please use [e-mail] instead)]

fix in hand.  I'll attach the patch.

this patch fixes this problem and makes searches for sender == "foo@bar" work 
again for news.

candidate for 0.9.2 and the trunk.

Comment 6

[(not reading, please use [e-mail] instead)]

*** Bug 86495 has been marked as a duplicate of this bug. ***

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: fix.

Comment 8

[(not reading, please use [e-mail] instead)]

fix in hand.  updating summary.   I suck for not getting to this sooner.  I'll 
try to land it on the branch, too.

Comment 9

[Cavin Song]

Looks good. r=cavin.

Comment 10

[(not reading, please use [e-mail] instead)]

this has sr=mscott

fixed on the trunk.

this is worth taking for 0.9.2, I'll seek approval.

Comment 11

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.2 branch.
(on behalf of drivers)

Comment 12

[(not reading, please use [e-mail] instead)]

moving back to 0.9.2 since I'm going to land on the branch, too.

Comment 13

[Christopher Blizzard (:blizzard)]

Reopening so that it stays on drivers for 0.9.2.  Please close it once it hits
the branch.

Comment 14

[(not reading, please use [e-mail] instead)]

fix landed on the 0.9.2 branch.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED on both trunk _and_ branch using a new profile with:

Server: news.mozilla.org
Newsgroup: netscape.public.mozilla.mail-news
Criteria: Sender contains @

Search brought 13,596 results on builds:

Trunk - 

Windows 2K - 2001-07-10-09
Mac OS 9.1 - 2001-07-10-08
RedHat 7.1 - 2001-07-10-08

Branch -

Windows 2K - 2001-07-10-05-0.9.2
Mac OS 9.1 - 2001-07-10-03-0.9.2
RedHat 7.1 - 2001-07-10-08-0.9.2