841452 - Error message for busy page shows "&Don't ask me again."

Status: RESOLVED DUPLICATE of bug 821405

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e
Gaia   6544fdb8dddc56f1aefe94482402488c89eeec49
BuildID 20130214070203
Version 18.0
Unagi
  
## Repro :
1. go to an etherpad page such as https://etherpad.mozilla.org/gaia-meeting-notes
2. zoom and pan around

## Expected :
1. if the script busy message appears the checkbox should not have an &

## Actual :
1. & shown

## Note :

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

ccing pike and stas in the event this could end up impacting l10n.  I recall a bug before that had a & and it did....

Comment 2

[Axel Hecht [:Pike]]

We should have disabled the hung-script prompt, you shouldn't manage to get to that screen. For exactly the reason that the prompt expects stuff we're not doing.

That was bug 820443.

Comment 3

[Ben Francis [:benfrancis]]

Yes this was disabled in bug 820443, but in trying to find a regression window I discovered it was re-enabled in bug 820438.

Gabriele, can you explain the rationale behind this?

https://github.com/mozilla/mozilla-central/commit/12c35831833b6352257e6513260efec5c7d859f7

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Ben Francis [:benfrancis] from comment #3)
> Gabriele, can you explain the rationale behind this?

We disabled the hung-script prompt because there wasn't a way to dismiss it permanently. This was because when we set the "Don't ask me again" flag a preference would be set and the change then reflected in the caller by a pref observer. However since the browser is a content process it can't set preferences, the observer with the change would never trigger and so the prompt would show up again.

What my patch does is to immediately apply the change to the calling process even if it failed to set the pref; this way the prompt is permanently dismissed if you chose "Don't ask me again" (at least until you restart the browser since the pref has not been set).

The "Don't ask me again" string is obtained via the following code:

  tmp = nsContentUtils::GetLocalizedString(nsContentUtils::eDOM_PROPERTIES,
                                           "DontAskAgain",
                                           neverShowDlg);

I can check if the returned string contains the '&' or if it's added by some other code.

Comment 5

[Axel Hecht [:Pike]]

It's in the strings, http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=DontAskAgain&find=dom.properties$

It's used as accesskey in the desktop modal dialogs.