841456 - Firefox win32 nightly l10n builds are broken

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alexander L. Slovesnik]

Looks like metro landing have broken compilation of Firefox win32 nightly l10n builds. For example, http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1360860320.1360860605.21403.gz shows:

e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/_virtualenv/Scripts/python.exe ../../toolkit/mozapps/installer/l10n-repack.py /e/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/browser/locales/../../dist/l10n-stage/firefox ../../dist/xpi-stage/locale-fr \
		
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/browser/locales'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/browser/locales'
Traceback (most recent call last):
  File "../../toolkit/mozapps/installer/l10n-repack.py", line 206, in <module>
    main()
  File "../../toolkit/mozapps/installer/l10n-repack.py", line 203, in main
    repack(args.build, args.l10n, args.non_resource)
  File "../../toolkit/mozapps/installer/l10n-repack.py", line 111, in repack
    for e in entries if isinstance(e, ManifestEntryWithRelPath))
  File "../../toolkit/mozapps/installer/l10n-repack.py", line 111, in <genexpr>
    for e in entries if isinstance(e, ManifestEntryWithRelPath))
KeyError: 'metro'
make[2]: *** [repackage-zip] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-fr] Error 2
program finished with exit code 2

Comment 1

[Jim Mathies [:jimm]]

My waterfall parsing abilities are a little rusty, but didn't these build run fine 2013/02/13?

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n&maxdate=1360826684&hours=24&legend=0&norules=1

Comment 2

[Jim Mathies [:jimm]]

Potentially a regression from bug 840598.

Comment 3

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #2)
> Potentially a regression from bug 840598.

sorry, incorrect bug number. bug 747347.

Comment 4

[Mike Hommey [:glandium]]

Looking at the l10n-repack code, it means there is nothing under metro in the langpack. So there must be something fishy in metro localization.

Comment 5

[Mike Hommey [:glandium]]

Looking at the full log, it never goes under browser/metro/locales.
http://tinderbox.mozilla.org/showlog.cgi?tree=Mozilla-l10n&errorparser=unix&logfile=1360860320.1360860605.21403.gz&buildtime=1360860320&buildname=Firefox%20mozilla-central%20win32%20l10n%20nightly&fulltext=1

Comment 6

[Mike Hommey [:glandium]]

Ah... the l10n builds don't have --enable-metro...

Comment 7

[Mike Hommey [:glandium]]

We just need to add ac_add_options --enable-metro to browser/config/mozconfigs/win32/l10n-mozconfig

Comment 8

[Mike Hommey [:glandium]]

Attachment: Enable metro on windows l10n builds

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/2e76c3b1feeb

Comment 10

[Bruno Pagani]

There haven't been any Firefox win32 l10n version built on mozilla-central since February 13th...

Is it because of this issue, or is it a new different one ?

Comment 11

[Jim Mathies [:jimm]]

checking for Windows SDK being recent enough... no
configure: error: You are targeting Windows version 0x06020000, but your SDK only supports up to version 0x06010000. Install and use an updated SDK, or target a lower version using --with-windows-version. Alternatively, try running the Windows SDK Configuration Tool and selecting a newer SDK. See https://developer.mozilla.org/En/Windows_SDK_versions for more details on fixing this.

Uh oh.

Armen, are l10n builders not the same as the m-c 64-bit builders?

Comment 12

[Armen [:armenzg]]

(In reply to Jim Mathies [:jimm] from comment #11)
> checking for Windows SDK being recent enough... no
> configure: error: You are targeting Windows version 0x06020000, but your SDK
> only supports up to version 0x06010000. Install and use an updated SDK, or
> target a lower version using --with-windows-version. Alternatively, try
> running the Windows SDK Configuration Tool and selecting a newer SDK. See
> https://developer.mozilla.org/En/Windows_SDK_versions for more details on
> fixing this.
> 
> Uh oh.
> 
> Armen, are l10n builders not the same as the m-c 64-bit builders?

They're the same.

Maybe they use different mozconfigs?

Adding coop since he has been looking at L10n work recently.

Comment 13

[Alexander L. Slovesnik]

(In reply to b.pagani from comment #10)
> There haven't been any Firefox win32 l10n version built on mozilla-central
> since February 13th...
> 
> Is it because of this issue, or is it a new different one ?

It's Bug 841740