841466 - Add GetParentObject() for WebIDL objects with a form owner

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We use the parent chain to implement the scope for event handlers, and we broke that.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=00e4bf7fa7e4

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 714038 [details] [diff] [review]
Patch v1

r=me.

We need this on 20, right?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca388aedb410

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 824007 (legend)
User impact if declined: possibly broken sites
Testing completed (on m-c, etc.): on inbound; passes try
Risk to taking this patch (and alternatives if risky): pretty low, fix is well understood and tested.
String or UUID changes made by this patch: None

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 714563 [details] [diff] [review]
Patch for aurora

Approving for aurora uplift even though this is only on inbound so far with the caveat that this pass testing and get merge to m-c before uplift to Aurora.  With the long weekend in the US it would be great if this can land before Tues 6am Pacific when we do the merge to beta.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca388aedb410

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/45e088f889e3

Comment 8

[Olli Pettay [:smaug]]

Oh, it does matter what kind of object is returned from GetParentObject.
Based on the documentation all that matters is that from the returned object one should eventually
get to the global.

Comment 9

[Boris Zbarsky [:bzbarsky]]

> Based on the documentation all that matters is that from the returned object one should 
> eventually get to the global.

That's true for all objects that can't be on a scope chain of some script.  As in, everything except nodes.