Closed Bug 841469 Opened 11 years ago Closed 11 years ago

BaselineCompiler: Fix arrayWriteHole behaviour on SETELEM

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: djvj, Assigned: djvj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

SETELEM IC doesn't currently set arrayWriteHole flag in situations where it should.  Fix.

This is suspected to be affecting ss-access-nsieve and ss-3d-morph.. probably others.
Assignee: general → kvijayan
Depends on: 841499
Attached patch Patch.Splinter Review
Once bug 841499 lands, this change will enable using the new SetObjectElement variant from baseline, fixing bug.
Attachment #714077 - Flags: review?(jdemooij)
Comment on attachment 714077 [details] [diff] [review]
Patch.

Review of attachment 714077 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #714077 - Flags: review?(jdemooij) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: