add most of the HTMLSelectElement webidl api

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
5 months ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

(Blocks 1 bug)

unspecified
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I don't want want to conflict with the HTMLOPtion patch, but the rest should be doable now.
Comment on attachment 714267 [details] [diff] [review]
bug 841484 - add most of the webidl HTMLSelectElement API

Review of attachment 714267 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; did you have any particular reason to pick the members you did?

::: content/html/content/src/nsHTMLSelectElement.h
@@ +276,5 @@
> +  nsHTMLFormElement* GetForm() const
> +  {
> +    return nsGenericHTMLFormElement::GetForm();
> +  }
> +  bool Required() const

FWIW, I'd put them in the same order the spec's IDL has; that would put required after name.
Attachment #714267 - Flags: review?(Ms2ger) → review+
I choose mostly by going through the spec and picking everything that seemed straight forward and didn't use HTMLOptionElement in one of its types
https://hg.mozilla.org/integration/mozilla-inbound/rev/c774937ce227
https://hg.mozilla.org/mozilla-central/rev/c774937ce227
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.