841572 - Work - Use "On"/"Off" for switch control instead of "Yes"/"No"

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

On Options flyout, currently we are using "Yes" and "No" for switch controls.

We should change that to the standard "On" and "Off".

Comment 1

[Matt Brubeck (:mbrubeck)]

Microsoft is inconsistent about this; for example People and Store use Yes/No, while Mail, Maps, and Music use On/Off.  Are there written guidelines?

Ah, found them: http://msdn.microsoft.com/en-us/library/windows/apps/hh465475.aspx

> Replace the On and Off labels when there are more specific labels
> for the setting. If there are short (3-4 characters) labels that
> represent binary opposites that are more appropriate for a particular
> setting, use them. For example, you might use "Show/Hide" if the
> setting is "Show images."
>
> Don't replace the On or Off label unless you must. You should use
> the default labels unless there are labels that are more specific
> for the setting.

So it sounds like On/Off is preferred over a different generic string like Yes/No.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Allison Naaktgeboren :ally]

Comment on attachment 714148 [details] [diff] [review]
patch

Review of attachment 714148 [details] [diff] [review]:
-----------------------------------------------------------------

why do you even need me for this? ;)

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a6c523cca4

Comment 5

[Matt Brubeck (:mbrubeck)]

Accidentally closed this early; reopening until it's merged to m-c.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f9a6c523cca4