I saw this as a TODO in the source https://github.com/mozilla/addon-sdk/blob/1afc3d73c6e20dc88e9aba91c6ff499d4fcf69ad/lib/sdk/request.js#L27
We could go as hard or as easy as we'd like, seems like this is a fun problem: http://mathiasbynens.be/demo/url-regex I'd rather a more liberal regex than an overly complex/slow/restrictive one as it'd be worse to not let a valid URL in than to let an invalid one work.
Comment on attachment 731958 [details] GH Pull Request 911 Thanks!
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/04c2a1196d0c047530b8fe508dc52971d5111bc1 Merge pull request #911 from jsantell/request-url-validation-841628 Fixes Bug 841628, Request Constructor Validates URL, r+=@erikvold
Oops I forgot that there was an api change here, and Irakli needs to approve that sort of thing. Can you take a look at this when you have a chance please Irakli?
Got a thumbs up from Irakli, after changing method name to `isValidURI`
needinfo is no longer relevant, as Jordan said I have replied in pull.