javascript strict warnings in PageInfoOverlay.xul

VERIFIED FIXED in psm2.1

Status

Core Graveyard
Security: UI
P2
normal
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: Henrik Gemal, Assigned: Kai Engert)

Tracking

({verifyme})

1.0 Branch
psm2.1
verifyme

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 69, Column: 10
Source Code:
          };

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 99, Column: 4
Source Code:
    };

Warning: redeclaration of var hdr
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 145, Column: 12
Source Code:
        var hdr = bundle.formatStringFromName("pageInfo_WeakEncryption",

Warning: redeclaration of var msg1
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 149, Column: 12
Source Code:
        var msg1 = bundle.formatStringFromName("pageInfo_Privacy_Weak1",

Warning: redeclaration of var msg2
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 153, Column: 12
Source Code:
        var msg2 = bundle.GetStringFromName("pageInfo_Privacy_Weak2");

Warning: redeclaration of var hdr
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 156, Column: 12
Source Code:
        var hdr = bundle.GetStringFromName("pageInfo_NoEncryption");

Warning: redeclaration of var msg1
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 159, Column: 12
Source Code:
        var msg1 = bundle.formatStringFromName("pageInfo_Privacy_None1",

Warning: redeclaration of var msg2
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 163, Column: 12
Source Code:
        var msg2 = bundle.GetStringFromName("pageInfo_Privacy_None2");
(Reporter)

Updated

17 years ago
Summary: javascript strict warnings in → javascript strict warnings in PageInfoOverlay.xul
->Crypto
Component: Security: General → Security: Crypto
really this time.
Assignee: mstoltz → ddrinan
QA Contact: ckritzer → junruh

Comment 3

17 years ago
Moving to Product: PSM for triage
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.0

Comment 4

17 years ago
-> p2
target -> 2.1
Priority: -- → P2
Target Milestone: --- → 2.1

Updated

17 years ago
Keywords: nsenterprise
(Assignee)

Comment 5

17 years ago
Created attachment 40923 [details] [diff] [review]
Patch to fix the reported syntax errors
(Assignee)

Comment 6

17 years ago
->kai

I was unable to test it, as I don't know the testcase for the messages. However,
there were simple syntax errors and I believe I fixed them.
Assignee: ddrinan → kai.engert
Keywords: patch, review
(Assignee)

Comment 7

17 years ago
David, please review.

Comment 8

17 years ago
r=ddrinan.
sr=blizzard
(Reporter)

Comment 10

17 years ago
who's up for a checkin?
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED

Comment 11

17 years ago
Mass assigning QA to ckritzer.
QA Contact: junruh → ckritzer

Comment 12

17 years ago
Checked in patch for Kai
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 13

17 years ago
keywords->verifyme
Keywords: patch, review → verifyme

Comment 14

17 years ago
Verified.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.