Closed Bug 841634 Opened 7 years ago Closed 7 years ago

Race condition in ContentParent: mChildID should be set in the constructor

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set

Tracking

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
B2G C4 (2jan on)
blocking-b2g tef+
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

(Whiteboard: QARegressExclude, [qa-])

Attachments

(1 file)

Right now mChildID is set to a unique value only during RecvGetProcessAttributes.  This sets us up for a race condition where we pass -1 to the wake lock manager and acquire a wake lock on behalf of the main process instead of on behalf of the child.

Patch in a moment.
Attached patch Patch, v1Splinter Review
Racey race race...
Attachment #714208 - Flags: review?(jones.chris.g)
Comment on attachment 714208 [details] [diff] [review]
Patch, v1

(Whew, I'm not in the blame for this one! ;) )

Nice find.
Attachment #714208 - Flags: review?(jones.chris.g) → review+
blocking-b2g: --- → tef+
Indeed, I reviewed the change.  :)
Assignee: nobody → justin.lebar+bug
https://hg.mozilla.org/mozilla-central/rev/6bb9636d8f68
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
(In reply to croesch from comment #7)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?

Not possible.
Whiteboard: QARegressExclude
No need to create a TC in Moztrap for this defect.
Flags: in-moztrap-
Whiteboard: QARegressExclude → QARegressExclude, [qa-]
You need to log in before you can comment on or make changes to this bug.