Closed
Bug 841634
Opened 12 years ago
Closed 12 years ago
Race condition in ContentParent: mChildID should be set in the constructor
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
(Whiteboard: QARegressExclude, [qa-])
Attachments
(1 file)
|
1.59 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Right now mChildID is set to a unique value only during RecvGetProcessAttributes. This sets us up for a race condition where we pass -1 to the wake lock manager and acquire a wake lock on behalf of the main process instead of on behalf of the child.
Patch in a moment.
|
Assignee | |
Comment 1•12 years ago
|
||
Racey race race...
Attachment #714208 -
Flags: review?(jones.chris.g)
Comment on attachment 714208 [details] [diff] [review]
Patch, v1
(Whew, I'm not in the blame for this one! ;) )
Nice find.
Attachment #714208 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Updated•12 years ago
|
blocking-b2g: --- → tef+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Indeed, I reviewed the change. :)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/67dbc9ee22d7
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d97927ce8c77
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → fixed
status-firefox19:
--- → wontfix
status-firefox20:
--- → wontfix
status-firefox21:
--- → fixed
Target Milestone: --- → B2G C4 (2jan on)
|
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 7•12 years ago
|
||
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
|
|
Assignee | |
Comment 8•12 years ago
|
||
(In reply to croesch from comment #7)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?
Not possible.
|
|
||
Updated•12 years ago
|
Whiteboard: QARegressExclude
No need to create a TC in Moztrap for this defect.
Flags: in-moztrap-
|
||
Updated•12 years ago
|
Whiteboard: QARegressExclude → QARegressExclude, [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•