841684 - [SMS][Edit mode] Thread is not created properly when receiving a message from a new number.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Being in the thread-list in edit-mode, if we receive a SMS the thread is not created properly.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Some modifications in rendering method.
User impact if declined: Threading is not working properly in SMS.
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 2

[Julien Wajsberg [:julienw]]

This happens also outside of edit mode.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 714295 [details]
Pull Request

r=me

I'd like a test for this bug before landing though.

To write such a test, write it before the change to make it fail, and check that it doesn't fail with the change.

This should really be eas, but please ping me if you need help !

Comment 4

[Borja Salguero [:borjasalguero]]

Hi Julien! I agree that we need to add more tests (more than one of two), So I've opened a bug for adding them and I would like to talk next week about it ok? Here is the bug https://bugzilla.mozilla.org/show_bug.cgi?id=841775 
By now Im gonna merge this one and request the approval-v1 because it's a regression. THanks!

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 714295 [details]
Pull Request

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Latest changes in rendering in threads.
User impact if declined: Threading is not working!
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low. But this patch it's so important if we want to have SMS App working as expected. Currently Threading is broken.

Comment 6

[Julien Wajsberg [:julienw]]

This fixes a regression introduced in Bug 827815.

Comment 7

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/53e7c0ea7110f29ff080680547fc5def81f5d6ce
(merge commit is https://github.com/mozilla-b2g/gaia/commit/53e7c0ea7110f29ff080680547fc5def81f5d6ce)

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 714295 [details]
Pull Request

Approving for v1-train and v1.0.1 alongside bug 827815.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 612bf320f228219d9e78d6f9da64057aa7d1fa09
v1.0.1: 6b8d17f2706700f09fb55a9aaa5202c270859344