841698 - Media storage available space is same as Music

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Kami]

On media storage page in Settings Music has same size as available space.

Comment 1

[Kami]

Attachment: Really Music has same space as available?

Comment 2

[David Palomino [:dpalomino]]

Issue reported in certification for Spain and LatAm (adding deps). 

Buildid "20130321070205", device: ikura
gecko commit: b5183c99228bdc5be33340e359efd1b4f0859e92 
gaia commit: 577d13088ebdbd353d13910d3317e713a140415b

Not a blocker for certification.

Comment 3

[Andrew Overholt [:overholt]]

Attachment: screenshot from my build

I don't see this with a build from 2013-04-12 (3e7dda889).

Comment 4

[Fabien Cazenave [:kaze]]

Attachment: screenshot

I confirm it works on my device, too: Unagi with latest Gecko (b2g18 branch) and Gaia (master branch). I tested with the latest v1.0.1 and v1-train branches, too — everything works fine here.

If you can reproduce this bug, please reopen and provide sharp information.

Comment 5

[Juan Perez-Bedmar [:juanpbf]]

I still reproduce this issue on Ikura
  build ID:20130426165700
  build information:
  gaia commit:
  e25b349 Merge pull request #9273 from gasolin/issue-863126
  gecko commit:
  6dfd179 Bug 849757 - Part 4: xpcshell tests. r=vicamo, a=tef+
  AU:V1.01.00.01.019.085

When I record a video with the handset, it is consider as Video data and Music data.
I'll add a screenshot

Comment 6

[Juan Perez-Bedmar [:juanpbf]]

Attachment: Screenshot after recording a video

Comment 7

[Andrew Overholt [:overholt]]

> When I record a video with the handset, it is consider as Video data and
> Music data.

I can reproduce *this* on my unagi with a v1.0.1 build from yesterday (gecko/gaia fd004d7126/cf2d4136f0).  But I think this is a separate issue than what was originally reported here.  I think it's best to close this bug and open a new one for that issue and put it as tef? since it wasn't what was originally tef+'d here.  Thanks.

Comment 8

[John Hammink]

I'm am still seeing this original issue on my 4/26 partner builds on both Inari and Ikura.

Comment 9

[Andrew Overholt [:overholt]]

Dave or Jan, can you investigate here?  Doug thinks it might be a devicestorage bug.

Comment 10

[Dave Hylands [:dhylands]]

The problem seems to stem from the fact that toolkit/content/devicestorage.properties has *.3gp listed for both videos and music.

DeviceStorage currently only looks file extensions when trying to determine the type of file a given file is.

Once bug 853732 lands, a given file will only be accumulated into one bucket, and videos is checked before music, so all *.3gp files will be considered to be videos.

So, the real question becomes, does DeviceStorage need to open the files and parse the metadata to determine if a *.3gp file contains only an audio stream, or has a video stream?

Comment 11

[Andrew Overholt [:overholt]]

(In reply to Dave Hylands [:dhylands] from comment #10)
> The problem seems to stem from the fact that
> toolkit/content/devicestorage.properties has *.3gp listed for both videos
> and music.

Ah :)

> So, the real question becomes, does DeviceStorage need to open the files and
> parse the metadata to determine if a *.3gp file contains only an audio
> stream, or has a video stream?

I would say no.

What about the original problem of media storage free space being equal to the space used by music files?

Comment 12

[Dave Hylands [:dhylands]]

(In reply to Andrew Overholt [:overholt] from comment #11)
> (In reply to Dave Hylands [:dhylands] from comment #10)
> > The problem seems to stem from the fact that
> > toolkit/content/devicestorage.properties has *.3gp listed for both videos
> > and music.
> 
> Ah :)
> 
> > So, the real question becomes, does DeviceStorage need to open the files and
> > parse the metadata to determine if a *.3gp file contains only an audio
> > stream, or has a video stream?
> 
> I would say no.
> 
> What about the original problem of media storage free space being equal to
> the space used by music files?

That's not free space, it's space used by the particular type. When you record a video, it gets saved as a .3gp file.

So when the settings app asked for how much space is used by videos, then the 3gp file is included in the total. And when settings asks for how much space is used by music, then the 3gp file gets included in that total as well. If the only media that you have is 3gp videos, then the 2 numbers will be the same.

Comment 13

[Dave Hylands [:dhylands]]

Hmm - I looked at all of the screenshots again. Let me see if there is something to explain the original problem.

Comment 14

[Dave Hylands [:dhylands]]

So I tried building with a v1.0.1 branch, and I also tried checking out the particular git hashes mentioned in comment 2, and I'm unable to reproduce the original problem (space left == music space)

I'm seeing 4 different numbers.

I was testing on a unagi, but there isn't any phone specific differences in device storage that I'm aware of.

Comment 15

[Andrew Overholt [:overholt]]

(In reply to John Hammink from comment #8)
> I'm am still seeing this original issue on my 4/26 partner builds on both
> Inari and Ikura.

Since John is able to reproduce this, what logs can he get to you to understand what's up here, Dave?

(I hope you don't mind me assigning this to you, Dave)

Comment 16

[Dave Hylands [:dhylands]]

Unfortunately, I don't think I have a phone that I can run an inari or ikura build on. Although maybe I can grab just the gecko/gaia bits or something. Can somebody point me to a flashable build that reproduces the problem?

I don't think that there is anything logged that would be worthwhile.

Getting the output of:

adb shell mount
adb shell df

would be useful. Does this happen from a fresh boot just by opening settings? Or do you have to go through a particular set of steps to get it to happen?

Comment 17

[Dave Hylands [:dhylands]]

I also just landed bug 853732 (on master, b2g18, and b2g_v1.0.1) which completely redoes the way used space is calculated.

It would be useful to know if a build done after that still shows the problem or not.

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

Juan, do you have a new build on your side to see if the new patch from bug 853732 works? Thanks 

(In reply to Dave Hylands [:dhylands] from comment #17)
> I also just landed bug 853732 (on master, b2g18, and b2g_v1.0.1) which
> completely redoes the way used space is calculated.
> 
> It would be useful to know if a build done after that still shows the
> problem or not.

Comment 19

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Joe Cheng [:jcheng] from comment #18)
> Juan, do you have a new build on your side to see if the new patch from bug
> 853732 works? Thanks 
I will try with tomorrow's nigthly version, that should already have that patch included and let you know the outcome.

BR

Comment 20

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Joe Cheng [:jcheng] from comment #18)
> Juan, do you have a new build on your side to see if the new patch from bug
> 853732 works? Thanks 

I have just tested last version available for Ikura:
QC RIL version:
    "ro.build.firmware_revision=V1.01.00.01.019.094"
gaia commit:
    1e598d8 Merge pull request #9213 from samjoch/follow-up-bug-823414
gecko commit:
    2140b2f Bug 867847 - Fix busted navigator.id.get(). r=benadida, a=tef+


and the patch seems to be working. After recording a video, the memory space consider as "Video" has increased its value but "Music" remains with same value.

Comment 21

[Joe Cheng [:jcheng] (please needinfo)]

let's give this one more day before we close it as WFM or dup it as bug 853732 
let's see if more folks can verify this one

Comment 22

[Andrew Overholt [:overholt]]

(In reply to Joe Cheng [:jcheng] from comment #21)
> let's give this one more day before we close it as WFM or dup it as bug
> 853732 
> let's see if more folks can verify this one

It's been > 1 day so WFM :)