Closed
Bug 841712
Opened 8 years ago
Closed 8 years ago
Copy in Error Console has some errors
Categories
(Toolkit Graveyard :: Error Console, defect)
Tracking
(firefox21+ fixed)
RESOLVED
FIXED
mozilla21
People
(Reporter: julienw, Assigned: jaws)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.42 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
This is in a current nightly: 21.0a1 (2013-02-14) STR: * open Error Console (_not_ the Web Console) * copy a line which has a line number * paste it in a text editor Expected: * we have the same informations as what is displayed Actual: * the line number is missing and sometimes some code is displayed instead For example, here is one example : Timestamp: 15/02/2013 13:40:12 Warning: TypeError: function WCF__outputMessageFromQueue does not always return a value Source File: chrome://browser/content/devtools/webconsole.js Line: return lastVisible ? node : null; , Column: 32 Source Code: return lastVisible ? node : null; See that the "line" line has the same text as in "source code", with a "column" information too (which is fine) Another example without a source code line : Timestamp: 15/02/2013 13:40:12 Warning: TypeError: function CommandController_isCommandEnabled does not always return a value Source File: chrome://browser/content/devtools/webconsole.js Line: (null) Here you see the line is "null" whereas it was displayed in the Console. This works correctly in Aurora.
Updated•8 years ago
|
Keywords: regression,
regressionwindow-wanted
Updated•8 years ago
|
Component: Developer Tools → Developer Tools: Console
Reporter | ||
Comment 1•8 years ago
|
||
I didn't want to use the "Console" component as it's not related to the Web Console but to our old beloved Error Console ;)
Comment 2•8 years ago
|
||
The Error Console has its own component in Toolkit.
Component: Developer Tools: Console → Error Console
Product: Firefox → Toolkit
Regressionn range: m-c good=2012-01-24 bad=2012-01-25 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=98ea4d294369&tochange=a207f33adc1a Suspected bug: Jared Wein — Bug 831020 - Errors in the error console with very long reference lines hang the browser. r=neil
Blocks: 831020
status-firefox21:
--- → affected
tracking-firefox21:
--- → ?
Keywords: regressionwindow-wanted
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Comment on attachment 714401 [details] [diff] [review] Patch Whoops, it's worse than I feared. "line" needs to be fixed in the subsequent line which is also using this.mSourceLine by mistake; this.mSourceLine actually belongs where it says this.getAttribute("code") further down! Meanwhile filterElement is now checking the source code twice :-( [Was bug 764346 supposed to filter on line?]
Attachment #714401 -
Flags: review?(neil) → review-
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #5) > [Was bug 764346 supposed to filter on line?] Yes, the Web Console allows filtering on line number so the idea was to make the two filters work the same way. See https://bugzilla.mozilla.org/show_bug.cgi?id=764346#c3.
Assignee | ||
Comment 7•8 years ago
|
||
Thank you for the quick review and sorry for not catching those other issues. I fixed the issue with filterElement searching the code twice so it now searches the line number. I kept the filtering on getAttribute("code") instead of mSourceLine for two reasons: 1) "code" is what is shown to the user and so it helps to show a user why a filtered entry is appearing 2) The lines are truncated for performance reasons, so filtering on extremely long lines won't be good for perf.
Attachment #714401 -
Attachment is obsolete: true
Attachment #714458 -
Flags: review?(neil)
Updated•8 years ago
|
Comment 8•8 years ago
|
||
Comment on attachment 714458 [details] [diff] [review] Patch v2 r=me on the toString change but the filterElement change should be reverted to the version prior to bug 831020 instead.
Attachment #714458 -
Flags: review?(neil) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/fb6dd685d3a9
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb6dd685d3a9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•5 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•