841762 - BaselineCompiler: Use correct scope chain for global scripts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Right now we use script->global() as scope chain, like IonMonkey, but I think this is only valid for compile-and-go scripts (Ion does not compile these). The browser has some code to execute global scripts with other objects as scope chain, and this bug breaks M-Oth on TBPL.

The attached patch just passes the scope chain to EnterJIT, like we already do for eval scripts.

Comment 1

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #0)
> only valid for compile-and-go scripts (Ion does not compile
> these).

Er, Ion compiles *only* CNG scripts.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 714381 [details] [diff] [review]
Patch

Review of attachment 714381 [details] [diff] [review]:
-----------------------------------------------------------------

Great that you went through and changed all the names to reflect the new semantics too.

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/projects/ionmonkey/rev/f3e499d59399