Closed
Bug 841762
Opened 13 years ago
Closed 13 years ago
BaselineCompiler: Use correct scope chain for global scripts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
11.42 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Right now we use script->global() as scope chain, like IonMonkey, but I think this is only valid for compile-and-go scripts (Ion does not compile these). The browser has some code to execute global scripts with other objects as scope chain, and this bug breaks M-Oth on TBPL.
The attached patch just passes the scope chain to EnterJIT, like we already do for eval scripts.
Attachment #714381 -
Flags: review?(kvijayan)
|
Assignee | |
Comment 1•13 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #0)
> only valid for compile-and-go scripts (Ion does not compile
> these).
Er, Ion compiles *only* CNG scripts.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 714381 [details] [diff] [review]
Patch
Review of attachment 714381 [details] [diff] [review]:
-----------------------------------------------------------------
Great that you went through and changed all the names to reflect the new semantics too.
Attachment #714381 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•