841790 - Fix newlines in &debug=1 output

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

When using &debug=1, eg:
https://tbpl.mozilla.org/php/getLogExcerpt.php?type=annotated&regenerate=1&id=19774648&debug=1

...the log output displays all on one line.

We either need to add <br /> between each log line, or else even better, make the mime-type "text/plain" so the browser displays it as is, and doesn't mangle it.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

I know how much you love php... ;-)

Comment 2

[Jeff Hammel]

Comment on attachment 714446 [details] [diff] [review]
Patch v1

I dunno...looks too straight forward to be a PHP patch :P  Though I guess the fact that its a double check vs e.g. python _GET.get('debug') == '1' is good enough.

Good find, Ed.   I didn't even know about that URL

Comment 3

[Ed Morley [:emorley]]

In production.