Closed Bug 841815 Opened 12 years ago Closed 12 years ago

Re-enable gaia unit tests on Travis

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rik, Assigned: yurenju)

References

Details

Attachments

(1 file)

pull request
180 bytes, text/html
timdream
: review+
Details
Now that bug 838993 has landed, we should re-enable those tests.
Assignee: nobody → yurenju
Bug 841251 broken email and calendar unit test, kevin is working on it. after this bug fixed I will re-enable travis :D
test case for calendar _sendAlarmNotification always failed. I spent whole day and have no idea about it, so I will disable it and file a bug for re-enable _sendAlarmNotification test case.
I can save you some time: I've already filed Bug 840489 for misbehaving unit tests in the Calendar app.
Attached file pull request —
https://github.com/mozilla-b2g/gaia/pull/8179 I'll also active travis integration when this commit landed.
Attachment #715190 - Flags: review?(mike)
This looks good, but I'm not sure about the implications of changing the CI server to use Nightly. My fear is that we'll be more exposed to regressions. I'll see if I can get a second opinion.
especially that nightly does not work these days...
It's apparently working now--TravisCI is reporting that the tests are green on the pull request: https://github.com/mozilla-b2g/gaia/pull/8179 ...but the larger question remains. I should also make it clear that Yuren's work is specifying a static version of Nightly, which, although probably safer than latest nightly, feels somewhat arbitrary.
And apologies to Yuren--"arbitrary" is a bit of a loaded word. What I meant by that is it would be better to be explicit about which version runs in CI and why.
I knew recent nightly broken, that's why I used the first version of Feb which I have tested for runnung unit tests. we should use a fixed version of firefox since recent nightly is unstable for unit tests just like bug 841711. any idea for which nightly version we should use?
Disccussed with Tim offline, we should use recent nightly because developers always use nightly running tests with automatic update. I'm investigating how to get the latest nightly. this link should be work but not... https://download.mozilla.org/?product=firefox-nightly-latest?os=linux&lang=en-US
I don't understand the rationale for choosing the latest Nightly. We're running these tests to ensure that we don't have regressions against the Gecko we'll use in the final products. So I think we should use something like http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-b2g18/
I didn't know we had firefox builds from the b2g18 branch. I totally agree with Anthony for that. However this "latest b2g18" should also be updated. So let's first enable back the tests, and then Yuren, could you file a new bug for choosing the right Firefox ?
Running the tests on a current nightly branch makes some test fail, eg Bug 842500. Therefore I believe we should really run the tests in a b2g18 Firefox. However we should also run them in a nightly to catch early some problems, but maybe not in Travis ?
quick_settings_test.js also failed on b2g18 firefox, but I found the root cause. pull request is on the way.
Mike, pull request updated! test case failed on access MozActivity and it also failed when I try to use |if(window.MozActivity)| or |if(typeof(MozActivity) !== 'undefined'| to avoid it.
Comment on attachment 715190 [details] pull request stealing, r+ :)
Attachment #715190 - Flags: review?(mike) → review+
This is great! Nice work, Yuren (and thanks for reviewing, Tim) :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: